Skip to content

Fix Set Producer metadata on saved document when provided#1761

Open
guidimas wants to merge 1 commit intoHopding:masterfrom
guidimas:fix-set-producer-metadata
Open

Fix Set Producer metadata on saved document when provided#1761
guidimas wants to merge 1 commit intoHopding:masterfrom
guidimas:fix-set-producer-metadata

Conversation

@guidimas
Copy link
Copy Markdown

What?

When provided, Producer info is stored in the saved document.

Why?

Producer info was getting overwritten before saving the document, even when setProducer was called before.

How?

Modified PDFDocument.ts to use the default value for Producer only when this information was not provided or updated using setProducer.

Testing?

PDFDocument unit test updated to cover this scenario.

Screenshots

N/A

Suggested Reading?

Yes

Anything Else?

N/A

Checklist

  • I read CONTRIBUTING.md.
  • I read MAINTAINERSHIP.md#pull-requests.
  • I added/updated unit tests for my changes.
  • I added/updated integration tests for my changes.
  • I ran the integration tests.
  • I tested my changes in Node, Deno, and the browser.
  • I viewed documents produced with my changes in Adobe Acrobat, Foxit Reader, Firefox, and Chrome.
  • I added/updated doc comments for any new/modified public APIs.
  • My changes work for both new and existing PDF files.
  • I ran the linter on my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant