jj: Change to libgit2@1.7#177765
Merged
BrewTestBot merged 2 commits intoHomebrew:masterfrom Jul 18, 2024
nicholasjng:jj-libgit2-change
Merged
jj: Change to libgit2@1.7#177765BrewTestBot merged 2 commits intoHomebrew:masterfrom nicholasjng:jj-libgit2-change
BrewTestBot merged 2 commits intoHomebrew:masterfrom
nicholasjng:jj-libgit2-change
Conversation
github-actions
bot
added
the
rust
Contributor
Author
|
Needs a |
Depend on libgit2@1.7 instead of the unpinned version. jj itself currently expects libgit2 < 1.8, so this change allows the dynamic linker to pick up the right shared library. jj: rev bump Signed-off-by: Rui Chen <rui@chenrui.dev>
Member
|
relates to #166767 |
cho-m
approved these changes
Jul 18, 2024
4 tasks
Contributor
|
🤖 An automated task has requested bottles to be published to this PR. |
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depend on libgit2@1.7 instead of the unpinned version. jj itself currently expects libgit2 < 1.8, so this change allows the dynamic linker to pick up the right shared library.
Addresses #177686.
New contributor, just thought I'd submit it quickly after the encouragement in #177686 (comment).
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?