fix(frontend): add uid for upload components

[yassinedorbozgithub]

Motivation

The main motivation is to fix a multi upload selection bug.

Fixes #972

Type of change:

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• I have performed a self-review of my own code
• New and existing unit tests pass locally with my changes

Summary by CodeRabbit

• Bug Fixes
  • Improved the AttachmentUploader to ensure file input and label are uniquely linked, preventing issues when multiple uploaders are used on the same page.

[coderabbitai]

Walkthrough

The change updates the AttachmentUploader React component to use the useId hook for generating a unique identifier for its file input and label elements. This replaces the previous static ID, ensuring each component instance maintains unique associations and preventing conflicts when multiple uploaders are rendered.

Changes

File(s)	Change Summary
frontend/src/app-components/attachment/AttachmentUploader.tsx	Replaced static file input/label ID with a dynamic value using React's useId hook for uniqueness.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AttachmentUploader
    participant React

    User->>AttachmentUploader: Render multiple instances
    AttachmentUploader->>React: Call useId()
    React-->>AttachmentUploader: Provide unique uid
    AttachmentUploader->>AttachmentUploader: Assign unique id to input/label
    User->>AttachmentUploader: Interact with file input/label
    AttachmentUploader->>AttachmentUploader: Correctly associates input and label via unique id

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Ensure each AttachmentUploader instance maintains unique file input/label association (#972)	✅

Suggested reviewers

• marrouchi

Poem

A rabbit hops with code anew,
Unique IDs for uploads too!
No more mix-ups in the field,
Each attachment now is sealed.
With React’s hook, the bugs are through—
Hooray for uploads, clear and true!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 933daaa and 4981f72.

📒 Files selected for processing (1)

• frontend/src/app-components/attachment/AttachmentUploader.tsx (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: API-Tests
• GitHub Check: Frontend Tests
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (3)

frontend/src/app-components/attachment/AttachmentUploader.tsx (3)

20-20: LGTM! Proper import addition for unique ID generation.

The addition of useId to the React imports is correct and necessary for implementing unique identifiers.

---

91-91: LGTM! Correct usage of React's useId hook.

Using the useId hook is the recommended React approach for generating unique, stable identifiers that work consistently across server and client renders.

---

158-162: Excellent fix for the multi-upload selection bug!

The dynamic ID implementation correctly addresses the core issue:

1. Fixes duplicate ID problem: Replaces static "file-upload" ID with unique file-upload${uid}
2. Maintains accessibility: The label's htmlFor attribute correctly references the input's unique ID
3. Enables multiple instances: Multiple AttachmentUploader components can now coexist without ID conflicts

This change properly resolves issue #972 and follows HTML standards requiring unique element IDs.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.