Fix segments contains#1354
Open
Kubuzer wants to merge 2 commits into
Open
Conversation
Contributor
|
I think we'll not accept unit test files for the moment, please remove it from this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request implements the missing non-convex (concave) shape support in
h2d.col.Segments.containsPointand introduces a headless unit testing suite.Changes:
h2d.col.Segments: Replaced the placeholderthrow "TODO"exception incontainsPoint(whenisConvex = false) with a ray-casting (winding number) algorithm to support concave polygons.test/running on the Haxe compiler interpreter (--interp) to ensure headless tests can run on any platform.hxd.Math(clamp,nextPOT,isPOT,lerp, etc.).h2d.col.Segmentsverifying both convex and concave polygon containment.h3d.impl.ShaderCacheensuring shaders are cached in memory whenallowSave = false.