Add Sticky Brown Basic Variants & Create a Variant Walkthrough Contributing.md #2976
Conversation
* Add Basic Sticky Suits * Added Sticky Brown and Sticky Dark Brown Basic Variants
|
Meant to Update my main branch, Not sure it's fully ready yet, making this a draft for now |
VS Code is making the first Sticky Dark Brown Variant entry format Inconsistent with all the other ones, not sure why but maybe it is just a prettier thing I don't understand?
Added a Create Variant Walkthrough in addition to the Create Sticky Brown Variants at the request of James
|
It's all green Finally :). Have added a Create a new Variant walkthrough as requested. Feel free to edit Contributing.md further as you see fit. I have only created 1 Variant Group so have probably missed some things. As far as the Variant is concerned, I made decisions in my new Suit ID's that I thought did not conflict with any existing patterns I found for already existing suit id's. For example the Modified Red Suit ID is presently SRN. I came to with S for Sticky R for the Clue Color Red and N for the Clue Color Brown. There were some other patterns I thought maybe these suits would fit into and am open to changing the suit id's if the group prefers a different pattern be used. Trying to think ahead to when the new variant scheme without variant numbers but with strictly suit id's takes effect and trying to keep things as simple as possible when the website users enter the Suit ID's. There are some existing Suit ID's I think would benefit changing internally to accomplish this goal. Maybe these are better considered in a future pull request though. |
|
i'll try to take a look this weekend |
|
can you remove dark brown from the PR? new variants are supposed to be trial, meaning only with the base suits |
Fioralor
changed the title
| @@ -573,5 +573,40 @@ | |||
| "displayName": "Teal", | |||
| "pip": "hanabiAltWhite", | |||
| "clueColors": ["Green", "Blue"] | |||
| }, | |||
| { | |||
| "name": "Red N", | |||
There was a problem hiding this comment.
I just used a similar notation to how dual color suits were named (they were appended with the letter D), Appending with N seemed reasonable for adding the Clue Color Brown to the suit. If there is a different notation you want me to follow there instead it can be changed.
|
is there an existing issue for the Sticky Brown variant? |
|
What is meant by existing issue? |
|
a github issue proposing how the variant should work and so on |
|
The issue is now added #2977. I was probably supposed to do the issue before the pr, sorry for not doing that. |
|
It looks like contributing.md has been updated already to add the create a variant walkthrough. I have updated the pr contributing.md to match it in order to avoid future conflicts. I'm not sure if I should just rename the pr again to remove the contributing.md half now or keep it since part of this pr's history was helping to add the create a variant walkthrough. Either option seems reasonable. |
|
I had some irl stuff come up for the past few weeks. I meant to close my own pr with a comment. Self Closing this pr for the variant idea being too similar to already existing variants. |
Adds Variants where Colored Non-Brown Suits have been modified to also be able to be Clued by the Brown Color Clue to add an additional challenge to the Brown Suit