Conversation
- Rewrote the 'sign up for new account with existing username' test in spec/features/signup_spec.rb. - Replaced UI-driven setup of an existing user with FactoryBot's `create`. - Replaced UI navigation with a direct call to `new_member_registration_path`. - Added an explicit assertion for the 'has already been taken' error message. - Ensured a unique email is used for the second signup attempt to isolate the username validation check. Co-authored-by: CloCkWeRX <365751+CloCkWeRX@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
I have refactored the signup feature test in
spec/features/signup_spec.rbas requested. The test now sets up the existing user directly in the database using FactoryBot and navigates directly to the signup route using Rails helpers, rather than relying on UI interactions for setup. I also added an assertion to verify that the validation error for an existing username is correctly displayed.PR created automatically by Jules for task 10681697950343780211 started by @CloCkWeRX