Skip to content

chore: update the opendal to 0.56 rc2#8003

Merged
evenyag merged 20 commits intoGreptimeTeam:mainfrom
shuiyisong:chore/update_opendal_to_rc2
Apr 26, 2026
Merged

chore: update the opendal to 0.56 rc2#8003
evenyag merged 20 commits intoGreptimeTeam:mainfrom
shuiyisong:chore/update_opendal_to_rc2

Conversation

@shuiyisong
Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

As the title suggests.

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@github-actions github-actions Bot added size/XL docs-not-required This change does not impact docs. labels Apr 20, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a significant upgrade of the opendal dependency to v0.56.0-rc.2 and introduces a compatibility adapter, OpendalStore, to support object_store 0.12. These changes necessitate updates to storage operations, such as transitioning from remove_all to delete_with and adjusting metadata retrieval logic. Review feedback identifies several critical improvements for the new compatibility layer: ensuring opendal::Buffer is correctly converted to Bytes in the read stream and utilizing metakey during object listing to fetch metadata efficiently and avoid performance-degrading N+1 stat requests.

Comment thread src/object-store/src/compat.rs
Comment thread src/object-store/src/compat.rs
Comment thread src/object-store/src/compat.rs Outdated
Comment thread src/object-store/src/compat.rs
Comment thread src/object-store/src/compat.rs
Comment thread src/object-store/src/compat.rs
@shuiyisong shuiyisong force-pushed the chore/update_opendal_to_rc2 branch from 4dd7a3a to ba5bbb0 Compare April 22, 2026 06:24
@github-actions github-actions Bot added the ci label Apr 22, 2026
@shuiyisong shuiyisong marked this pull request as ready for review April 22, 2026 12:52
@shuiyisong shuiyisong requested review from a team, WenyXu, v0y4g3r and waynexia as code owners April 22, 2026 12:52
Comment thread src/object-store/src/compat.rs Outdated
Comment thread src/servers/src/grpc.rs Outdated
Comment thread tests/runner/Cargo.toml
Signed-off-by: shuiyisong <xixing.sys@gmail.com>
Signed-off-by: shuiyisong <xixing.sys@gmail.com>
Signed-off-by: shuiyisong <xixing.sys@gmail.com>
Signed-off-by: shuiyisong <xixing.sys@gmail.com>
Signed-off-by: shuiyisong <xixing.sys@gmail.com>
Signed-off-by: shuiyisong <xixing.sys@gmail.com>
Signed-off-by: shuiyisong <xixing.sys@gmail.com>
Signed-off-by: shuiyisong <xixing.sys@gmail.com>
Signed-off-by: shuiyisong <xixing.sys@gmail.com>
Signed-off-by: shuiyisong <xixing.sys@gmail.com>
@shuiyisong shuiyisong force-pushed the chore/update_opendal_to_rc2 branch from d4cf020 to 1dc9265 Compare April 23, 2026 07:39
Signed-off-by: shuiyisong <xixing.sys@gmail.com>
Signed-off-by: shuiyisong <xixing.sys@gmail.com>
Signed-off-by: shuiyisong <xixing.sys@gmail.com>
Signed-off-by: shuiyisong <xixing.sys@gmail.com>
Signed-off-by: shuiyisong <xixing.sys@gmail.com>
Comment thread src/servers/src/grpc.rs Outdated
Comment thread tests-fuzz/targets/failover/fuzz_failover_metric_regions.rs Outdated
Comment thread tests-fuzz/Cargo.toml Outdated
Comment thread src/common/meta/src/kv_backend/rds.rs Outdated
Copy link
Copy Markdown
Member

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/common/meta/src/kv_backend/rds.rs Outdated
Comment thread src/object-store/src/compat.rs Outdated
Signed-off-by: shuiyisong <xixing.sys@gmail.com>
Comment thread src/object-store/src/compat.rs
@github-actions github-actions Bot added size/XXL and removed size/XL labels Apr 26, 2026
shuiyisong and others added 3 commits April 26, 2026 17:17
Signed-off-by: shuiyisong <xixing.sys@gmail.com>
Signed-off-by: evenyag <realevenyag@gmail.com>
Signed-off-by: evenyag <realevenyag@gmail.com>
Signed-off-by: evenyag <realevenyag@gmail.com>
@evenyag evenyag force-pushed the chore/update_opendal_to_rc2 branch from 2e33088 to 5e7b44c Compare April 26, 2026 09:25
@evenyag evenyag enabled auto-merge April 26, 2026 09:27
@evenyag evenyag disabled auto-merge April 26, 2026 09:28
@evenyag evenyag enabled auto-merge April 26, 2026 09:43
@evenyag evenyag added this pull request to the merge queue Apr 26, 2026
Merged via the queue into GreptimeTeam:main with commit 0effc30 Apr 26, 2026
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci docs-not-required This change does not impact docs. size/XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants