Skip to content

Conversation

@frankienstan
Copy link

@frankienstan frankienstan commented Sep 7, 2023

Description

Fixes # Fixes an issue where '\\n' characters in wallet.about content were not rendered correctly as line breaks. Replaced '\n' with '<br>' tags to ensure proper line breaks in the rendered HTML content.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@frankienstan frankienstan changed the title feat: replace '\n' with '<br/>' for line breaks in wallet.about Fix: replace '\n' with '<br/>' for line breaks in wallet.about Sep 8, 2023
dangerouslySetInnerHTML={{
__html: marked.parse(wallet.about || 'NO DATA YET'),
__html: marked.parse(
(wallet.about || 'NO DATA YET').replace(/\\n/g, '<br/>'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frankienstan thank you for your work, because the about is in markdown format, so I don't think you should use html tag <br/> here, you should replace with newline \n and give it to marked.parse to generate the content (in html)

BTW, can paste a screenshot of the result?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dadiorchen Yea sure ,
Before
before
After
after

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, the
can do the work of breaking new line, but we don't need to do this by ourselves, we just need to fix the extra \\n for the string, and pass it to markdown lib, it will take care of all the work including the newline breaking

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can replacing \n with actual newline characters \n in the wallet.about content before passing it to marked.parse(). This way, marked.parse() will handle the Markdown rendering, including line breaks, as expected.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frankienstan yes, exactly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants