-
Notifications
You must be signed in to change notification settings - Fork 61
Impact value #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dadiorchen
wants to merge
27
commits into
Greenstand:master
Choose a base branch
from
dadiorchen:impact-value
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Impact value #233
Changes from 13 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
e2168ab
Modified docs/api/spec/treetracker-token-api.yaml
dadiorchen 1067a2e
Modified docs/api/spec/treetracker-token-api.yaml
dadiorchen f617690
Modified docs/api/spec/treetracker-token-api.yaml
dadiorchen 3076d4d
remove wrong lines
dadiorchen eb8adc1
chore: remove wrong lines.
dadiorchen 8512be6
Modified docs/api/spec/treetracker-token-api.yaml
dadiorchen 5fc0c4f
Merge branch 'eb8adc16c69f20732881fed60301036256ace689' into impact-v…
dadiorchen e4ba7b1
Modified docs/api/spec/treetracker-token-api.yaml
dadiorchen 7b55d2d
Merge remote-tracking branch 'greenstand/master' into impact-value
dadiorchen b0565db
chore: define test for impact value
dadiorchen fdfc7d3
chore: merge from master
dadiorchen fda5aa2
Modified docs/api/spec/treetracker-token-api.yaml
dadiorchen 675f134
Modified docs/api/spec/treetracker-token-api.yaml
dadiorchen 467df14
chore: coding
dadiorchen c227654
chore: impact value request
dadiorchen 649a073
chore: impact value
dadiorchen 874e34b
Merge branch 'impact-value' of github.com:dadiorchen/treetracker-toke…
dadiorchen 2feba88
chore: can transfer impact value having trust
dadiorchen 57f4a7d
chore: can response with impact value
dadiorchen 3ab886c
chore: accept can response with impact value
dadiorchen 5837b4b
chore: unit test on money change problem
dadiorchen 3ac6580
chore: remove only test
dadiorchen 8c41458
chore: claim is correct
dadiorchen 81bb2e0
feat: can fulfill impact transfer
dadiorchen 94cad7b
chore: pass all tests
dadiorchen 1b00682
docs: fulfill rule for impact value
dadiorchen b758ccc
fix: got stale data
dadiorchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
|
|
||
| describe('Zaven request to send 4 impact value to Meisze', () => { | ||
|
|
||
| beforeEach(async () => { | ||
| }) | ||
|
|
||
| it("Meisze accept the request, then token worth 4 impact should belong to Meisze", () => { | ||
| }); | ||
|
|
||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZavenArra For the impact value transfer, I added the field called
impact_value_transferedin the response, to indicate the actual impact value has been transferred in the transfer operation.Also, I will return this field in the
acceptandfulfillendpoint if needed.What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And @ZavenArra another question, should we need to set the value_matrix_id parameter for the impact value transfer?