Skip to content

Standardize row height and cell alignment in EntityDataTable#26586

Draft
ousmaneo wants to merge 1 commit into
masterfrom
refactor/entity-data-table-visual-refresh
Draft

Standardize row height and cell alignment in EntityDataTable#26586
ousmaneo wants to merge 1 commit into
masterfrom
refactor/entity-data-table-visual-refresh

Conversation

@ousmaneo

@ousmaneo ousmaneo commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Motivation

The entity data table is the most-used surface in the UI, but rows had ragged heights, top-aligned content, no vertical gridlines, and permanently visible column drag/resize controls. This PR tacks the table toward an improved style tables (uniform rows, calmer headers, clearer column separation).

Changes

  • Standardized row heightROW_MIN_HEIGHT (38px) on data rows and override rows; cell content is vertically centered and single-line with ellipsis truncation by default. Columns whose content must wrap (e.g. the streams title cell) can opt out via a new wrapContent flag on ColumnRenderer.
  • Column dividers — a border-right (same token as row dividers) is drawn only between attribute columns, so the bulk-select and (possibly empty) actions columns don't produce stray lines.
  • Horizontal centering — cell content is centered by default by wiring up the previously unused ColumnRenderer.textAlign; title/name columns default to left via DefaultColumnRenderers, and link-rendering columns (index_set_title, event_definition_id, lookup table cache_id/ data_adapter_id) opt out per table.
  • Hover-revealed header controls — column drag and resize handles fade in on header hover/focus (kept visible during an active drag/resize, and always visible on touch devices via @media (hover: none)).
  • Streams title cell — reserves a two-line box (min-height: 2lh) so rows with and without a description have identical height; a lone title centers vertically.
    /nocl

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have requested a documentation update.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant