Standardize row height and cell alignment in EntityDataTable#26586
Draft
ousmaneo wants to merge 1 commit into
Draft
Standardize row height and cell alignment in EntityDataTable#26586ousmaneo wants to merge 1 commit into
ousmaneo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The entity data table is the most-used surface in the UI, but rows had ragged heights, top-aligned content, no vertical gridlines, and permanently visible column drag/resize controls. This PR tacks the table toward an improved style tables (uniform rows, calmer headers, clearer column separation).
Changes
ROW_MIN_HEIGHT(38px) on data rows and override rows; cell content is vertically centered and single-line with ellipsis truncation by default. Columns whose content must wrap (e.g. the streams title cell) can opt out via a newwrapContentflag onColumnRenderer.border-right(same token as row dividers) is drawn only between attribute columns, so the bulk-select and (possibly empty) actions columns don't produce stray lines.ColumnRenderer.textAlign;title/namecolumns default to left viaDefaultColumnRenderers, and link-rendering columns (index_set_title,event_definition_id, lookup tablecache_id/data_adapter_id) opt out per table.@media (hover: none)).min-height: 2lh) so rows with and without a description have identical height; a lone title centers vertically./nocl
Types of changes
Checklist: