Add search query preview extension point for event definitions#26557
Closed
danotorrey wants to merge 3 commits into
Closed
Add search query preview extension point for event definitions#26557danotorrey wants to merge 3 commits into
danotorrey wants to merge 3 commits into
Conversation
Adds a read-only effective-query preview under the Search Query on the Filter & Aggregation event definition condition screen, with a persisted show/hide toggle and copy-to-clipboard. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The event-definitions SearchFilter type requires id, title, disabled and negation; the test fixture was missing them (caught by the tsgo compiler in CI). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Search filters are enterprise-only, so the effective-query preview is now provided by the enterprise plugin. OSS only exposes a generic eventDefinitions.components.searchQueryPreview extension point beneath the Search Query on the event definition condition screen; the read-only field and toggle move to the enterprise plugin. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
danotorrey
changed the title
Contributor
Author
|
Closing — the effective-query capability is shipping as a backend-only endpoint in Graylog2/graylog-plugin-enterprise#14718, which needs no graylog2-server change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a generic extension point —
eventDefinitions.components.searchQueryPreview— beneath the Search Query on the Filter & Aggregation event definition condition screen.FilterFormrenders any registered plugin component with the current base query and applied search filters.This is the OSS-side hook for the enterprise effective-query preview (Graylog2/graylog-plugin-enterprise#14718). The preview itself lives in the enterprise plugin, since search filters are an enterprise feature; OSS only provides the mount point.
Assisted with Claude Code