-
-
Notifications
You must be signed in to change notification settings - Fork 988
Add missing StartTransaction for ToggleSelectedVisibility (#3381) #3382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing StartTransaction for ToggleSelectedVisibility (#3381) #3382
Conversation
|
!build |
|
|
@dhiraj-143r did you intend to close the pr? |
|
i am solving it |
|
actually i am new to open source contribution so , |
|
In that case, please change the pr state back to a draft (I'll do that now), you can mark it as ready to review once you have verified that the original issue is solved (try the reproduction from the issue) and once you have made sure that you have not committed any intermediate debugging steps etc. |
9c355d9 to
94414ad
Compare
|
i have open the pr |
|
Is there a reason why you made a new pr instead of marking the old one as ready for review? |
|
I wasn’t aware I could simply mark the existing draft PR as “Ready for review”. I thought creating a new one was required |
|
sorry about that!, you want me to open this PR only ? |
|
I guess we can continue with the new one, but in the future, please don't open multiple prs because that makes it harder to track the context |

Closes #
This PR fixes issue #3381, where hiding/unhiding a layer did not always update the document’s saved state correctly.
The issue was that the ToggleSelectedVisibility did not start a transaction