Skip to content

Conversation

@dhiraj-143r
Copy link

Closes #

This PR fixes issue #3381, where hiding/unhiding a layer did not always update the document’s saved state correctly.

The issue was that the ToggleSelectedVisibility did not start a transaction

Screenshot 2025-11-15 at 1 13 41 PM

@TrueDoctor
Copy link
Member

!build

@github-actions
Copy link

📦 Build Complete for 9c355d9
https://df803b95.graphite.pages.dev

@TrueDoctor
Copy link
Member

@dhiraj-143r did you intend to close the pr?

@dhiraj-143r
Copy link
Author

i am solving it

@dhiraj-143r dhiraj-143r reopened this Nov 15, 2025
@dhiraj-143r
Copy link
Author

dhiraj-143r commented Nov 15, 2025

actually i am new to open source contribution so ,
it is taking more time to solve it

@TrueDoctor
Copy link
Member

In that case, please change the pr state back to a draft (I'll do that now), you can mark it as ready to review once you have verified that the original issue is solved (try the reproduction from the issue) and once you have made sure that you have not committed any intermediate debugging steps etc.

@TrueDoctor
Copy link
Member

image for your reference this is where you can change the prs status

@TrueDoctor TrueDoctor marked this pull request as draft November 15, 2025 09:33
@dhiraj-143r dhiraj-143r marked this pull request as ready for review November 15, 2025 10:24
@dhiraj-143r dhiraj-143r marked this pull request as draft November 15, 2025 10:24
@dhiraj-143r dhiraj-143r force-pushed the fix-layer-visibility-transaction branch from 9c355d9 to 94414ad Compare November 15, 2025 11:05
@dhiraj-143r dhiraj-143r deleted the fix-layer-visibility-transaction branch November 15, 2025 11:11
@dhiraj-143r
Copy link
Author

i have open the pr
will u please check it once

@dhiraj-143r dhiraj-143r restored the fix-layer-visibility-transaction branch November 15, 2025 11:54
@TrueDoctor
Copy link
Member

Is there a reason why you made a new pr instead of marking the old one as ready for review?

@dhiraj-143r
Copy link
Author

I wasn’t aware I could simply mark the existing draft PR as “Ready for review”. I thought creating a new one was required

@dhiraj-143r
Copy link
Author

dhiraj-143r commented Nov 15, 2025

sorry about that!,

you want me to open this PR only ?

@TrueDoctor
Copy link
Member

I guess we can continue with the new one, but in the future, please don't open multiple prs because that makes it harder to track the context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants