Skip to content

Promote identity and effective_identity in reasoningengine (AgentEngine) to GA#16900

Merged
rileykarson merged 1 commit intoGoogleCloudPlatform:mainfrom
mmontan:identity-ga
Apr 6, 2026
Merged

Promote identity and effective_identity in reasoningengine (AgentEngine) to GA#16900
rileykarson merged 1 commit intoGoogleCloudPlatform:mainfrom
mmontan:identity-ga

Conversation

@mmontan
Copy link
Copy Markdown
Contributor

@mmontan mmontan commented Apr 1, 2026

Promote the fields google_vertex_ai_reasoning_engine.spec.identity_type and google_vertex_ai_reasoning_engine.spec.effective_identity to the GA provider

vertexai: promoted `spec.identity_type` and `spec.effective_identity` fields in `google_vertex_ai_reasoning_engine` resource to GA

Fixes hashicorp/terraform-provider-google#26758

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 116 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 4 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccVertexAIReasoningEngine_vertexAiReasoningEngineIdentityTypeUpdate

Tests analytics

Total tests: 88
Passed tests: 85
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages
  • vertexai

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 116 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 4 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccVertexAIReasoningEngine_vertexAiReasoningEngineIdentityTypeUpdate

Tests analytics

Total tests: 88
Passed tests: 85
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages
  • vertexai

🟢 All tests passed!

View the build log

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 4, 2026
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 4, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 117 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 5 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 117 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 5 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccVertexAIReasoningEngine_vertexAiReasoningEngineIdentityTypeUpdate

Tests analytics

Total tests: 88
Passed tests: 85
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages
  • vertexai

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccVertexAIReasoningEngine_vertexAiReasoningEngineIdentityTypeUpdate

Tests analytics

Total tests: 88
Passed tests: 85
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages
  • vertexai

🟢 All tests passed!

View the build log

@mmontan mmontan marked this pull request as ready for review April 4, 2026 14:51
@github-actions github-actions bot requested a review from rileykarson April 4, 2026 14:52
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Copy link
Copy Markdown
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rileykarson rileykarson added this pull request to the merge queue Apr 6, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 03b41aa Apr 6, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Promote identity_type and effective_identity to GA in VertexAIReasoningEngine

3 participants