-
Notifications
You must be signed in to change notification settings - Fork 309
Update stable
branch up to release 2.6.1
#527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This updates the URL for the pom to point to the `main` branch.
Adds a new demo activity that shows how to launch partial custom tab. The demo contains the usage of APIs introduced to customize its behavior and user interface.
Partial custom tab demo
The notification sample did not work as it didn't get migrated when raising the SDK target level.
Actions were broken as PendingIntent has not been migrated after updated the target SDK.
Migrate notification sample
Fix Custom UI sample
Update the url for the pom
Only set SubscriptionUpdateParams only if purchaseToken is set
TWA based apps might want to listen to CCT call back events and take appropriate action ( eg. capture metrics about usage). Since the field currently is private and used in launchTWA() its not possible for the extending classes to change the behavior. This change pulls out the private field and creates a overridable method that supplies the Callback
Pull CustomTabsCallback to a getter from private field
Sets `webSettings.setMediaPlaybackRequiresUserGesture(false)`. This should be fine to set as default, as we want to mimic the behaviour a platform-specific app would have and play media by default. See #413
Allows media playback without user interaction on WebViewFallback
Argument to setFlags should be one of WindowManager.LayoutParams not a View Flag.
Use WindowManager.LayoutParams.FLAG_FULLSCREEN to go full screen.
Add Custom Tabs Engagement Signals Demo
updated the version number in readme
Forward Launch Handler client mode to a browser
Update Auth Tab demo browser dependency to alpha03
Incoming intent can contain FileData extra field in the case if LauncherActivity is relaunched in a separate task. It's related to navigate-new launch_handler client_mode becasue it requires launch in a new task. In this case we need to get FileData not from the data of the intent but from the extra field.
…ation Currently, the biggest bottleneck of app start up time is that the TWA app won't start the chrome until the enter animation is complete. For some Apps, it could take 500ms to play the animation and chrome just do nothing. It could help improve user experience if we can configure to start chrome early before enter animation complete. This commit adds a new metadata option, `START_CHROME_BEFORE_ANIMATION_COMPLETE`, to LauncherActivityMetadata. This option allows developers to control whether Chrome starts before or after the TWA enter animation completes. The current and default behavior is to start Chrome after the enter animation finishes, ensuring a smooth transition.
Use FileData from incoming intent if it's present
While app is waiting for enter animation complete, the chrome can preload the url. It could make web content loading around 300ms faster, which helps improve the app start-up time.
Add metadata option to control Chrome startup timing relative to anim…
Preload url while waiting for enter animation complete
android_browser_helper. They will be passed to the browser to calculate various metrics e.g. the duration from TWA launch to FCP. The version is needed to identify regression and improvements across different versions of android_browser_helper.
Add an extra data for TWA startup timestamp
1. Remove package namespace definition in Manifest. Setting the namespace via the package attribute in the source AndroidManifest.xml is no longer supported. 2. Specify an explicit value for `android:exported` when the component has an intent filter defined. 3. Add androidx.appcompat:appcompat build dependency in build.gradle 4. Complete the PwaWrapperSplashScreenStrategy()'s startChromeBeforeAnimationComplete argument in test
Since we are going to have several tasks of the same TWA in parallel we'll need to have separate sessions for each task. Therefore we will use task id value which is a hex number for session id instead.
Bump core version to 2.6.1
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
The CLA check failing is a little bit odd, but I think we're probably safe to ignore it since we're just merging from I see one of the "missing CLA" users, for example, is @EiraGe. At the time of the change, she was covered under the CLA by virtue of being a Google employee. I can't personally vouch for the other (@erikrodriguez-se), but I imagine it's a similar story. |
I've filed http://b/420907817 internally to double-check whether it's ok to ignore the CLA failure |
In #517 we added logic to report the version code, so make it clear that it should be bumped every release.
Add a reminder comment to bump version code
This will trigger copybaray to copy the changes into the internal repo (see #384)