Skip animation as default #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Remove package namespace definition in Manifest. Setting the namespace via the package attribute in the source AndroidManifest.xml is no longer supported. 2. Specify an explicit value for `android:exported` when the component has an intent filter defined. 3. Add androidx.appcompat:appcompat build dependency in build.gradle 4. Complete the PwaWrapperSplashScreenStrategy()'s startChromeBeforeAnimationComplete argument in test
ishitatsuyuki
suggested changes
May 22, 2025
Contributor
ishitatsuyuki
left a comment
ishitatsuyuki
left a comment
There was a problem hiding this comment.
From offline discussion, it seems PwaWrapperSplashScreenStrategyTest.java is still testing with startChromeBeforeAnimationComplete = false? I think we should ensure the defaults are tested, and if waitsForEnterAnimationCompletion_BeforeDeclaringReady breaks, we should state in the changelog that the API contract is changing.
The default behavior is to not wait enter animation complete before starting twa in browser. The waitsForEnterAnimationCompletion_BeforeDeclaringReady test does not need to be kept.
youenn98
force-pushed
the
skip_animation_as_default
branch
from
f3d8583 to
6de79c4
Compare
Contributor
Author
|
Yes, if we change the behavior to not wait on animation complete, the test waitsForEnterAnimationCompletion_BeforeDeclaringReady is not so meaningful. Added commits to delete it from current test suite. |
OlegNitz
approved these changes
Jun 11, 2025
youenn98
added a commit
to youenn98/android-browser-helper
that referenced
this pull request
Jun 12, 2025
The skip animation as default PR(GoogleChrome#520) changes behaviour of abh. Added the change description to changelog. Also, bump up the version & version code.
youenn98
added a commit
to youenn98/android-browser-helper
that referenced
this pull request
Jun 12, 2025
The skip animation as default PR(GoogleChrome#520) changes behaviour of abh. Added the change description to changelog. Also, bump up the version & version code.
youenn98
added a commit
to youenn98/android-browser-helper
that referenced
this pull request
Jun 12, 2025
The skip animation as default PR(GoogleChrome#520) changes behaviour of abh. Added the change description to changelog. Also, bump up the version & version code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make start chrome before animation complete as default behavior. Helps improve twa start-up time.