Skip to content

Set default padding to 0, not null #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2017
Merged

Set default padding to 0, not null #1648

merged 3 commits into from
May 7, 2017

Conversation

jeffs
Copy link
Contributor

@jeffs jeffs commented May 6, 2017

This fixes #1647 .

Copy link
Owner

@Glavin001 Glavin001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run npm run docs and commit documentation changes.

CHANGELOG.md Outdated
@@ -5,6 +5,7 @@
- Fix [#1643](https://github.com/Glavin001/atom-beautify/issues/1643). Add PHPCBF Version setting and remove "--no-patch" option from version 3.0 of PHPCBF. See [#1645](https://github.com/Glavin001/atom-beautify/pull/1645).
- Close [#27](https://github.com/Glavin001/atom-beautify/issues/27). Add commands for beautifying a specific language
- Add "Allow Risky" option for PHP-CS-Fixer. See [#1614](https://github.com/Glavin001/atom-beautify/pull/1614)
- Fix [#1647](https://github.com/Glavin001/atom-beautify/issues/1647), avoiding a spurious error message in the console.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message could be more informative. Consider Set Yaml padding default value to 0, removing Atom warning message "'atom-beautify.yaml.padding' could not set the default.".

@Glavin001 Glavin001 merged commit 67a897b into Glavin001:master May 7, 2017
@Glavin001
Copy link
Owner

Thank you for contributing!

@Glavin001 Glavin001 self-assigned this May 7, 2017
@Glavin001 Glavin001 added the bug label May 7, 2017
@jeffs
Copy link
Contributor Author

jeffs commented May 8, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'atom-beautify.yaml.padding' could not set the default
2 participants