feature: minify .js scripts in Files.copyAssetsFiles; added terser dependency #2318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al files are replaced with minified version in output/preview, because the original file name is referenced from .html files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Publii team!
While working with Simple theme, I noticed, that assets have 2 scripts.js files: one human readable and one minified.
The rendering process of Publii does not minify the .js files, instead, the Simple theme reference minified file directly from partials.
IMO, that is suboptimal and confusing.
Minification should be done inside rendering process.
So, I have made this PR.
Please, note, the PR contains also formatting changes, that affect irrelevant code.
UPD. Tested, works like a charm.