Crossbow Cartridges - Fix torch place fail playing placement sound #1231
+34
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misode
requested changes
Jan 4, 2026
...ow_cartridges/data/gm4_crossbow_cartridges/function/projectile/copper_torch/check.mcfunction
Outdated
Show resolved
Hide resolved
…into crossbow-cartridges-torch-sound-fix
Contributor
Author
|
Also added copper torch to Anyway these changes are now tested in game and work as intended |
misode
reviewed
Jan 12, 2026
| # place block sound | ||
| playsound minecraft:block.wood.place block @a[distance=..15] | ||
| execute unless score $torch_placed gm4_cb_misc matches 1 run loot spawn ~ ~ ~ loot minecraft:blocks/copper_torch | ||
| execute unless score $torch_placed gm4_cb_misc matches 1 run playsound minecraft:entity.item.pickup block @a[distance=..15] |
Member
There was a problem hiding this comment.
I don't think the score checks are correct here. They need to be opposite conditions. If the torch was placed, you play the sound, otherwise you spawn the loot table.
Contributor
Author
There was a problem hiding this comment.
That sound is for the item dropping so they should both happen at the same time. The sound for placing the torch is run from the place function, it was moved there and this item drop sound was added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1187