improve sftp mounts

[alexanderadam]

Well, this stuff is super complicated.
I probably did a lot of things not right but it works for me pretty well now.

I removed the symlink logic: I love it visually but it is indeed suuuuuuuuuuuper slow for some reason.
And I'm not the only one who realised this.

And regarding the deep link mount: I think it is related to this upstream bug.
So we can't tackle this until the SFTP issue is solved but this PR will simply open Nautilus at the mount point for now.

…ooor we decide to abandon gvfs. 😉

fixes #1203 #1861 #1857 #1794 #1610

[daniellandau]

@ferdnyc you looked into this in the past, could you maybe try to review this?

[daniellandau]

I haven't really used the mount functionality and reading up on the discussions it seems to have a long history of issues. Testing how it worked before this PR and after, this seems to be an improvement and doesn't seem to have direct downsides, except probably breaking/code conflicting other proposed solutions such as #1921 and #1793.

I'm inclined to go with this, let's say in one week from now if @ferdnyc or @andyholmes don't come with differing opinions.

I am aware that the nautilus sidebar continues to have a broken "permission denied" item after this PR too, but it has that now as well so it's not making things worse.

[andyholmes]

The sftp plugin has always been a bit flaky, so the most important thing is the code has been tested, but it looks reasonable to me. Outside of that, I think there might be some users who still depend on the symlink for a reliable path; not sure though.

[daniellandau]

After running this now for a while, it seems to leak umnount actions