Add dark theme support to webextension#2080
Merged
andyholmes merged 2 commits intoGSConnect:mainfrom Oct 31, 2025
expuss2000:webextension-dark-theme
Merged
Add dark theme support to webextension#2080andyholmes merged 2 commits intoGSConnect:mainfrom expuss2000:webextension-dark-theme
andyholmes merged 2 commits intoGSConnect:mainfrom
expuss2000:webextension-dark-theme
Conversation
andyholmes
approved these changes
Oct 31, 2025
Collaborator
andyholmes
left a comment
andyholmes
left a comment
There was a problem hiding this comment.
LGTM, just needs a rebase on the main branch, thanks!
added 2 commits
October 31, 2025 18:36
URL is a function and therefore causes the error "Function object could not be cloned"
Author
Rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also use buttons instead of only images to leverage browser default dark theme styles for hover/active states.
Light theme:
Dark theme:
I also had to make a small change to the JavaScript to replace
URL(that is now a function) withTARGET_URL(taken from #1977).Tested with Firefox 143.0.3 on Fedora 42.