Docker enhancement to grant the user the ability to modify the contai…#3150
Open
junaid-ebrahim wants to merge 1 commit intoGNS3:masterfrom
Conversation
…ner create Why: Several use cases require the need to alter the docker container create 1. Running systemd containers require special binds plus a custom termination signal 2. Running systemd in sysbox containers require custom runtime as well as Privileged=false 3. Many other use cases exist and will only grow as Docker becomes even more commonplace This change addresses the need by: 1. Adding a custom textedit to the Docker container Advanced tab 2. Adding the custom fields to the GNS3 schemas and objects 3. Adding logic to the Docker create function to merge the custom parameters NB: This change is depenant on modifications to both gns3-gui and gns3-server
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker - Add custom parameters to the container create
Why:
Several use cases require the need to alter the docker container create
This change addresses the need by:
NB: This change is depenant on modifications to both gns3-gui and gns3-server