#5040 Remove duplicate timeout setting#6187
Merged
Conversation
Collaborator
Author
|
Tried removing --timeout from AVA scripts to reduce duplicate timeout settings, but it's actually needed. Without it, AVA uses a default timeout which is too short — our browser tests often wait minutes for a pool slot, so AVA thinks nothing is happening and kills the run:
The three timeout layers each cover different things:
Removed TIMEOUT_OVERALL instead — it was 60min, always racing against TIMEOUT_ALL_RETRIES at 55min in the same Promise.race, so it could never win. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removed duplicate timeout setting
close #5040 // if this PR closes an issue
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):