fix(tabs): alignment issues with 'unsaved changes' badge in Tabs component#7038
Draft
talissoncosta wants to merge 2 commits intomainfrom
Draft
fix(tabs): alignment issues with 'unsaved changes' badge in Tabs component#7038talissoncosta wants to merge 2 commits intomainfrom
talissoncosta wants to merge 2 commits intomainfrom
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit in Settings → Usage.
Once credits are available, reopen this pull request to trigger a review.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
github-actions
bot
added
front-end
Contributor
Docker builds report
|
4 tasks
Replace <Row> and <div> wrappers in tab labels with fragments, and add a .btn-tab__label flex container in TabButton to keep text and badge inline. Remove redundant tabLabelString where tabLabel is already a plain string. Restore tab-nav-full for pill tab width. Closes #6935
The create-feature modal was refactored from .js to .tsx on main, so the original fix was lost during rebase. Apply the same fix: remove Row wrappers and redundant padding classes from tab labels, letting .btn-tab__label handle alignment. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
talissoncosta
force-pushed
the
fix/tab-badge-alignment-6935
branch
from
78fe7e8 to
ebb9004
Compare
talissoncosta
changed the title
Contributor
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Closes #6935
Supersedes #6949 — thanks to @alveyworld for the initial investigation and for flagging the group editor issue.
<Row>and<div>wrappers in tab labels with fragments, removing block-level elements that interfered with flex layout.btn-tab__labelwrapper inTabButtonwithinline-flexandflex-wrap: nowrapto keep text and badge on the same linetabLabelStringwheretabLabelis already a plain stringScreenshots
How did you test this code?
Manually verified the following:
*badge stays inline)*badge stays inline)