feat(utils/is_oss): Add a function to check oss deployment mode#44
Merged
feat(utils/is_oss): Add a function to check oss deployment mode#44
Conversation
for more information, see https://pre-commit.ci
Zaimwa9
approved these changes
Apr 7, 2025
Contributor
Zaimwa9
left a comment
Zaimwa9
left a comment
There was a problem hiding this comment.
Looks good to me (given isOss = not enterprise or saas) 👍
khvn26
reviewed
Apr 7, 2025
khvn26
reviewed
Apr 7, 2025
Member
khvn26
left a comment
khvn26
left a comment
There was a problem hiding this comment.
I'm cautious of these utility functions being used anywhere else than get_version_info — I think we should be careful introducing business logic dependent on this — however, I realise this will be used in the onboarding logic, not the core API/SDK logic, and this is OK to me.
khvn26
reviewed
Apr 7, 2025
khvn26
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Core, we need to add some conditional logic based on whether the build is OSS or not.