Skip to content

Creation of backup and restore statistics can be switched off #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

DevM900
Copy link
Contributor

@DevM900 DevM900 commented Jun 27, 2024

By setting the new property FbBackup.IncludeStatistics to false fixes #1180.
To ensure backward compatibility, the default value of the FbBackup.IncludeStatistics property is true.

@cincuranet
Copy link
Member

I'm wondering whether instead of introducing new property making Statistics nullable would do the same job...

@DevM900
Copy link
Contributor Author

DevM900 commented Jul 11, 2024

My initial intention was not to change any existing property.
But I think making the Statistics property nullable is also fine.
When I think about the users of the class, however, I can't judge which is the better solution.

@DevM900
Copy link
Contributor Author

DevM900 commented Jul 12, 2024

If you prefer nullable, I'd change that.

@cincuranet
Copy link
Member

Yeah, I would go with nullable. Unless it blows in some unexpected way, it seems better to me.

To perform a backup or restore without determining the statistics values, the `Statistics` property can be set to `null`.
The property `IncludeStatistics` is therefore no longer required.
@DevM900
Copy link
Contributor Author

DevM900 commented Jul 12, 2024

Done.

DevM900 added 2 commits July 15, 2024 11:21
To perform a restore without determining the statistics values, the `Statistics` property can be set to `null`.
The property `IncludeStatistics` is therefore no longer required.
@DevM900 DevM900 requested a review from cincuranet July 17, 2024 05:33
Copy link
Member

@cincuranet cincuranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cincuranet cincuranet merged commit 4d174f3 into FirebirdSQL:master Jul 17, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create backup on firebird server 2.0
2 participants