-
Notifications
You must be signed in to change notification settings - Fork 7
GRAPH.ACL command documentation #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Updated formatting and corrected syntax in the GRAPH.ACL documentation.
WalkthroughA new Markdown documentation file for the GRAPH.ACL command has been added, providing detailed information about the command's purpose, syntax, subcommands (SETUSER, GETUSER, DELUSER, LIST), usage patterns, supported rules, examples, and expected responses. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
commands/graph.acl.md (3)
19-25: Reconcile the subcommand ordering.The subcommands list (lines 19-25) shows the order as GETUSER, SETUSER, DELUSER, LIST, but the detailed sections follow the order SETUSER, GETUSER, DELUSER, LIST. Either reorder the list to match the sections or reorganize the sections to match the list for consistency.
### Subcommands - 1. `GETUSER` - 2. `SETUSER` - 3. `DELUSER` - 4. `LIST` + 1. `SETUSER` + 2. `GETUSER` + 3. `DELUSER` + 4. `LIST`
93-98: Add an example and expected output to the LIST section for consistency.The SETUSER and GETUSER sections include examples and expected responses, but the LIST section only shows the command syntax without an example or sample output. Adding these would enhance clarity and consistency with the other sections.
#### GRAPH.ACL LIST Lists all existing users. ```text GRAPH.ACL LIST
- Example:
- GRAPH.ACL LIST
- Response:
- "john"
- "jane"
--- `35-41`: **Consider clarifying the distinction between +GRAPH.QUERY and +GRAPH.RO_QUERY.** The SETUSER section lists both `+GRAPH.QUERY` and `+GRAPH.RO_QUERY` in the supported rules, and the example grants both permissions. A brief note clarifying whether these are mutually exclusive, complementary, or if one is a subset of the other would help users understand the permission model better. </blockquote></details> </blockquote></details> <details> <summary>📜 Review details</summary> **Configuration used**: CodeRabbit UI **Review profile**: CHILL **Plan**: Pro <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 6f2c2bba102e8d976aa54ba6dc9af68ed33ff350 and f281964c1ed08b81c6c6cc51b79d326bee541f1c. </details> <details> <summary>📒 Files selected for processing (1)</summary> * `commands/graph.acl.md` (1 hunks) </details> <details> <summary>🧰 Additional context used</summary> <details> <summary>🧠 Learnings (1)</summary> <details> <summary>📓 Common learnings</summary>Learnt from: gkorland
Repo: FalkorDB/docs PR: 89
File: commands/acl.md:0-0
Timestamp: 2024-12-04T13:48:42.158Z
Learning: Incommands/acl.md, it's acceptable to include actual password values like>password123in example outputs for documentation purposes.</details> </details> </details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
Updated formatting and corrected syntax in the GRAPH.ACL documentation.
Summary by CodeRabbit