Django 5.2 support #1123
Django 5.2 support #1123
Conversation
| django42: Django>=4.2,<5.0 | ||
| django51: Django>=5.1,<5.2 | ||
| django52: Django>=5.2,<6 | ||
| djangomain: Django>5.1,<6.0 |
There was a problem hiding this comment.
This one should probably be bumped too? Otherwise it might be testing the same as above... We might have to revert to downloading from source as there is no 6.0 on PyPI yet:
| djangomain: Django>5.1,<6.0 | |
| djangomain: https://github.com/django/django/archive/main.tar.gz |
There was a problem hiding this comment.
While I completely agree with your suggestion, I’m not sure this change should be included in this PR. It’s unrelated to the scope of the current work and would be better handled in a separate PR. I’m a strong proponent of keeping PR titles and bodies aligned with their actual changes.
PS. This sounds like a great idea for a contribution from you @browniebroke -wink-wink-
There was a problem hiding this comment.
... Otherwise I'll do it in another PR
There was a problem hiding this comment.
Well, you're argument makes some sense... However, I'm going to make another one which may also makes sense (I think):
This PR adds support to a new version of Django, and doing so means that "django main" should keep pointing to the next version, which means updating this 😄
Anyway, I'll leave it up to a maintainer to decide. There is a gap in my understanding as to why it was changed away from installing from source in the first place, maybe they can shed some light on that.
There was a problem hiding this comment.
I'd like to handle djangomain: https://github.com/django/django/archive/main.tar.gz in another PR when this gets merged.
|
@francoisfreitag while you're at it... |
|
@francoisfreitag you don't have merge powers anymore? 😇 |
|
I do, but I’m letting a chance for other maintainers to chime in before to merge PRs. I usually wait a couple weeks between approval and the actual merging. |
4 participants
Fixes: #1122
Adds [official] support for Django 5.2