Conversation
| if (referenceSpatialReference == null) { | ||
| _spatialReferenceStatus = | ||
| BasemapGalleryItemSpatialReferenceStatus.unknown; | ||
| } else if (_spatialReference == referenceSpatialReference) { |
There was a problem hiding this comment.
This should be
(_spatialReference.wkid == referenceSpatialReference.wkid)
There was a problem hiding this comment.
We’re trying to detect a spatial reference mismatch; comparing only the WKID can miss mismatches for others.
|
It is nice to have different folders to classify the MVC classes. Since each folder only has one class, and the class name has been self-identified, we could move the classes under one folder and focus on the public API, hiding the internal implementation in a different folder. |
|
Thank you again for all your feedback! I’ve incorporated the changes into the repo, and the branch has been updated. Please take a look when you have a chance, and let me know if there’s anything else I can improve. I’m always open to suggestions. Thanks! |
PaulAllanSturm
left a comment
There was a problem hiding this comment.
added a few more comments
jenmerritt
left a comment
There was a problem hiding this comment.
I've built the API ref and done a re-review of the public API and design - have a few more queries below. Overall it's feeling a lot closer to design though.
I plan to do some user testing and throw some data at it on Monday 👀
jenmerritt
left a comment
There was a problem hiding this comment.
This has come along way @martinoyovo , nice work. To the point where I've really hammered it in user quality testing today. I think some of these should be written up as individual tasks, but take the time to read through and maybe we can sync up on them to go through. Perhaps you can also experiment with some of the things I've been testing.
32212e3 to
f7f6f42
Compare
The
BasemapGalleryis a UI component that lets a user browse a collection of basemaps and apply a selection to a connectedGeoModelvia aBasemapGalleryController.The basemaps shown in the gallery are provided by the controller (defaults, a portal, or custom items), and the current selection is tracked by the controller.
Features
Usage
Provide a
BasemapGalleryControllerand place the gallery in your widget tree.Simulator.Screen.Recording.-.iPhone.17.Pro.Max.-.2025-12-31.at.13.12.19.mov