Open
Conversation
Yesssssman
requested changes
Mar 8, 2026
Collaborator
Yesssssman
left a comment
Yesssssman
left a comment
There was a problem hiding this comment.
LGTM, but we need to keep backward compatibility for non-player sensitive methods in CapabilityItem.
neoforge/src/main/java/yesman/epicfight/skill/guard/GuardSkill.java
Outdated
Show resolved
Hide resolved
neoforge/src/main/java/yesman/epicfight/world/capabilities/item/BowCapability.java
Show resolved
Hide resolved
neoforge/src/main/java/yesman/epicfight/world/capabilities/item/CapabilityItem.java
Show resolved
Hide resolved
…ttack() legacy method for addons as well.
introduced a bunch of new registries and preparing for datapack compatibility.
Forixaim
added
the
public api
Collaborator
|
Seems good. I recommend putting deprecation annotations with info on some of the modified API methods. |
sentwayfarer
requested changes
Mar 11, 2026
Collaborator
sentwayfarer
left a comment
sentwayfarer
left a comment
There was a problem hiding this comment.
I misread. Please put comments on the deprecation annotations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds ExCap into Epic Fight with respective fallback methods inside the method for legacy and addon developers to slowly port into Epic Fight