[1.21.1] Add Javadocs for CombatKeyMapping#2171
Merged
Yesssssman merged 1 commit intoEpic-Fight:1.21.1from Nov 7, 2025
Merged
Conversation
EchoEllet
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be honest, I prefer to remove any code that is confusing and does nothing meaningful, as future maintainers would assume this is useful in some way, so they think it's there for a reason, but there is just an inconsistency that makes it hard to maintain.
Issue
For now, the best thing we could do is to document the existing confusing code while noting that we're not 100% about its usefulness, and we just hope that some other mods make use of this metadata, or it would be useful with other modded keybinds.
Justification
We have already spent quite some time on Discord trying to figure out an answer, and this is a minor issue, so we need to focus on more important priorities.
Unfortunately, this NeoForge doc section appears to be copied and pasted from MinecraftForge.