Compat package organization#2168
Merged
Yesssssman merged 1 commit intoEpic-Fight:1.21.1from Nov 5, 2025
Merged
Conversation
This was referenced Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactoring moves files from
compat.${mod_name}Compattocompat.${mod_name}.${mod_name}Compat.This change allows us to keep everything related to a mod’s compatibility in a single package.
For example, we may need to use
ICompatModulewith a mixin too. With the current structure, related files are spread across different packages, even though they belong to the same mod:mixin.${mod_name}compat.${mod_name}CompatThey should instead be grouped in one package, which also includes the mixins, registered only if the mod is installed.
This approach is more scalable and allows related classes to be grouped under the same domain.
To keep the review simple, I’ll include this refactoring in a separate PR.
Regarding backporting this change to 1.20.1: there’s one mod that modifies
PlayerAnimatorCompat, so they’ll need to update the import (one line).Tip
Technically, they’re mixing into an internal Epic Fight API.
I could submit a PR to their mod to fix the issue after releasing for 1.20.1, or we could skip backporting this change for that version — though that would lead to more inconsistencies over time.