Skip to content

Enabled >21m for issued assets in GUI amount field#1540

Open
tomt1664 wants to merge 1 commit intoElementsProject:masterfrom
tomt1664:gui_issued_asset_amounts
Open

Enabled >21m for issued assets in GUI amount field#1540
tomt1664 wants to merge 1 commit intoElementsProject:masterfrom
tomt1664:gui_issued_asset_amounts

Conversation

@tomt1664
Copy link
Member

Only pegged asset limited to MAX_MONEY for the GUI amount field. Issued assets can have amounts displayed > MAX_MONEY.

Copy link
Member

@delta1 delta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 56b2572; ran tests locally but have not tested the GUI

Comment on lines +128 to +131
if (val.first == Params().GetConsensus().pegged_asset)
{
val.second = qMin(val.second, BitcoinUnits::maxMoney());
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think your editor added some tabs here, not a blocking issue though

Suggested change
if (val.first == Params().GetConsensus().pegged_asset)
{
val.second = qMin(val.second, BitcoinUnits::maxMoney());
}
if (val.first == Params().GetConsensus().pegged_asset) {
val.second = qMin(val.second, BitcoinUnits::maxMoney());
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants