Solution - #1 - Nishitha - 10/05/2025 #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSexpl
reviewed
May 10, 2025
You can add multiple solutions, as well as their explanations. The idea is to start from a not so optimized solution, and gradually move to an optimized solution. You can follow this for reference: https://github.com/Dijkstra-Edu/LeetCode-Solutions/pull/3/files |
JRS296
reviewed
May 10, 2025
Comment on lines
+1
to
+13
| class Solution { | ||
| public: | ||
| bool containsDuplicate(vector<int>& nums) { | ||
| sort(nums.begin(), nums.end()); // O(n log n) | ||
| for (int i = 1; i < nums.size(); ++i) { | ||
| if (nums[i] == nums[i - 1]) { | ||
| return true; | ||
| } | ||
| } | ||
| return false; | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
- The File name is not following convention.
- There is no explanation.md file. Kindly read it and have a clear understanding on how to proceed. You can use the template file: https://github.com/Dijkstra-Edu/LeetCode-Solutions/blob/master/Explanation-Template.md
- Also use these merged PR's for reference: https://github.com/Dijkstra-Edu/LeetCode-Solutions/pulls?q=is%3Apr+is%3Aclosed
JRS296
reviewed
May 10, 2025
Comment on lines
+1
to
+12
| class Solution { | ||
| public: | ||
| bool containsDuplicate(vector<int>& nums) { | ||
| sort(nums.begin(), nums.end()); // O(n log n) | ||
| for (int i = 1; i < nums.size(); ++i) { | ||
| if (nums[i] == nums[i - 1]) { | ||
| return true; | ||
| } | ||
| } | ||
| return false; | ||
| } | ||
| }; |
There was a problem hiding this comment.
Same as the solution above. And not following convention. It should be 1 Solution at a time. Follow the Folder structure.
JRS296
requested changes
May 10, 2025
|
Also the title is still not clear. Kindly have a look at the readme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Explanation
Problem Statement
Given an integer array
nums, returntrueif any value appears at least twice in the array, and returnfalseif every element is distinct.Approach
Code Explanation
sort(nums.begin(), nums.end());: Sorts the array in ascending order.for (int i = 1; i < nums.size(); ++i): Iterates through the array starting from the second element.if (nums[i] == nums[i - 1]): Checks if the current element is equal to the previous one.return true;: Returns true immediately upon finding a duplicate.return false;: If no duplicates are found after the loop, returns false.