-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Wizcli improvements #12446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: bugfix
Are you sure you want to change the base?
Wizcli improvements #12446
Conversation
This pull request contains multiple low-confidence findings related to potential security and parsing weaknesses in the wizcli_common_parsers, including risks of information disclosure, imprecise URL matching, hardcoded severity limitations, logging exposure, and broad exception handling that could reveal system internals. 💭 Unconfirmed Findings (5)
All finding details can be found in the DryRun Security Dashboard. |
✅ Test Scan Results – Parser Behavior & Deduplication1.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @OsamaMahmood for your extensive PR. We do have some feedback:
- Could you look at updating the tests/samples scans to reflect the updates to the parsers?
- Could you look using the hash code configuration for deduplication?
I just raised #12463 to clarify the use of the unique_id_from_tool
field. It's intended/accepted use is to contain value present in the report that can be used to recognize the finding inside the tool. And for strong and exact deduplication.
We will discuss internally if/how we can accomodate values computed by the parser that might be useful for deduplication.
Description
_generate_unique_id
method to ensure consistent finding deduplication usingunique_id_from_tool
:Checklist
This checklist is for your information.
dev
.dev
.bugfix
branch.