Skip to content

add recipe for handling flaky tests #4752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

emmettbutler
Copy link

What does this PR do?

This change adds brief and generic documentation about how to handle test unreliability

Motivation:

This change aims to make it easier for new contributors to become effective in this repo.

Change log entry

Additional Notes:

How to test the change?

@emmettbutler emmettbutler requested a review from a team as a code owner June 20, 2025 20:34
@emmettbutler emmettbutler requested a review from TonyCTHsu June 20, 2025 20:34
@github-actions github-actions bot added the docs Involves documentation label Jun 20, 2025
Copy link

github-actions bot commented Jun 20, 2025

👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-06-24 12:11:48 UTC

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (cd3ce6a) to head (e61304e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4752      +/-   ##
==========================================
- Coverage   97.56%   97.55%   -0.01%     
==========================================
  Files        1486     1486              
  Lines       88583    88583              
  Branches     4586     4586              
==========================================
- Hits        86425    86418       -7     
- Misses       2158     2165       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jun 20, 2025

Datadog Report

Branch report: emmett.butler/flaky-guidance
Commit report: e61304e
Test service: dd-trace-rb

✅ 0 Failed, 21770 Passed, 1296 Skipped, 4m 45.15s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jun 20, 2025

Benchmarks

Benchmark execution time: 2025-06-20 21:04:53

Comparing candidate commit ad5fa4a in PR branch emmett.butler/flaky-guidance with baseline commit 2646e78 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 42 metrics, 5 unstable metrics.

@p-datadog
Copy link
Member

We don't presently seem to run any tests for contributor PRs automatically (e.g. see: #4543). An employee has to push the code to this repo (which contribuotrs have no permission to do) for CI to run. I don't know if contributors will be able to restart any failing jobs either.

@TonyCTHsu
Copy link
Contributor

@p-datadog , @emmettbutler is employed at Datadog. The Gitlab job failed without useful information only doc changes pull request.

@TonyCTHsu TonyCTHsu changed the title add recipe for handling flaky tests [LANGPLAT-352] add recipe for handling flaky tests Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Involves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants