Skip to content

.gitlab/one-pipeline.locked.yml : GHCR -> ECR migration #4732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

pawelchcki
Copy link
Contributor

@pawelchcki pawelchcki commented Jun 13, 2025

Updates .gitlab/one-pipeline.locked.yml . This version of the pipeline uses ECR instead of GHCR for tests. As a temporary fix for vaccine, dd-trace-rb is published to GHCR as well. This will break when Classic PATs are deprecated

@pawelchcki pawelchcki requested a review from a team as a code owner June 13, 2025 09:28
Copy link

github-actions bot commented Jun 13, 2025

👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-06-23 18:59:20 UTC

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (cd3ce6a) to head (2f6928e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4732      +/-   ##
==========================================
- Coverage   97.55%   97.55%   -0.01%     
==========================================
  Files        1486     1486              
  Lines       88582    88582              
  Branches     4586     4586              
==========================================
- Hits        86416    86413       -3     
- Misses       2166     2169       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Jun 13, 2025

Benchmarks

Benchmark execution time: 2025-06-23 18:33:29

Comparing candidate commit 6ad6a5e in PR branch auto-update-one-pipeline with baseline commit cd3ce6a in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 6 unstable metrics.

scenario:profiling - Allocations ()

  • 🟩 throughput [+188488.534op/s; +234088.205op/s] or [+6.054%; +7.518%]

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this PR is automatically generated, but how can I validate that this change is correct, e.g. that an older or broken version of the file isn't being added?

@TonyCTHsu
Copy link
Contributor

I understand this PR is automatically generated, but how can I validate that this change is correct, e.g. that an older or broken version of the file isn't being added?

I understand the test might just be green, but I shared similar concern. A mysterious SHA updated does not really tell much of a story. It would ideal to provide with an increment of version number and descriptive changelog.

@ivoanjo
Copy link
Member

ivoanjo commented Jun 13, 2025

Extra +1 on the version number: I think if there was something kind of like that, I could check "yeah we're going from v1.3.7 to v1.4.1" but with a hash I have no idea in what direction we're going.

@p-datadog
Copy link
Member

I think if a human is expected to approve this PR, it follows that a human is expected to read it, which means the PR should contain a similar description to what human-generated PRs contain. Probably filling out the PR template would be good?

@pawelchcki pawelchcki force-pushed the auto-update-one-pipeline branch from d93c08a to 684aa81 Compare June 23, 2025 15:36
@pawelchcki pawelchcki marked this pull request as draft June 23, 2025 15:45
@pawelchcki pawelchcki force-pushed the auto-update-one-pipeline branch from 684aa81 to c98fff1 Compare June 23, 2025 15:46
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jun 23, 2025

Datadog Report

Branch report: auto-update-one-pipeline
Commit report: 2f6928e
Test service: dd-trace-rb

✅ 0 Failed, 21769 Passed, 1296 Skipped, 4m 34.65s Total Time

@randomanderson randomanderson added dev/ci Involves CircleCI, GitHub Actions, or GitLab dev/internal Other internal work that does not need to be included in the changelog labels Jun 23, 2025
@randomanderson randomanderson changed the title Update .gitlab/one-pipeline.locked.yml .gitlab/one-pipeline.locked.yml : GHCR -> ECR migration Jun 23, 2025
@randomanderson randomanderson marked this pull request as ready for review June 23, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/ci Involves CircleCI, GitHub Actions, or GitLab dev/internal Other internal work that does not need to be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants