-
Notifications
You must be signed in to change notification settings - Fork 394
.gitlab/one-pipeline.locked.yml : GHCR -> ECR migration #4732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description. If changes need to be present in CHANGELOG.md you can state it this way **Change log entry**
Yes. A brief summary to be placed into the CHANGELOG.md (possible answers Yes/Yep/Yeah) Or you can opt out like that **Change log entry**
None. (possible answers No/Nope/None) Visited at: 2025-06-23 18:59:20 UTC |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4732 +/- ##
==========================================
- Coverage 97.55% 97.55% -0.01%
==========================================
Files 1486 1486
Lines 88582 88582
Branches 4586 4586
==========================================
- Hits 86416 86413 -3
- Misses 2166 2169 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2025-06-23 18:33:29 Comparing candidate commit 6ad6a5e in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 6 unstable metrics. scenario:profiling - Allocations ()
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this PR is automatically generated, but how can I validate that this change is correct, e.g. that an older or broken version of the file isn't being added?
I understand the test might just be green, but I shared similar concern. A mysterious SHA updated does not really tell much of a story. It would ideal to provide with an increment of version number and descriptive changelog. |
Extra +1 on the version number: I think if there was something kind of like that, I could check "yeah we're going from v1.3.7 to v1.4.1" but with a hash I have no idea in what direction we're going. |
I think if a human is expected to approve this PR, it follows that a human is expected to read it, which means the PR should contain a similar description to what human-generated PRs contain. Probably filling out the PR template would be good? |
d93c08a
to
684aa81
Compare
684aa81
to
c98fff1
Compare
Datadog ReportBranch report: ✅ 0 Failed, 21769 Passed, 1296 Skipped, 4m 34.65s Total Time |
Updates .gitlab/one-pipeline.locked.yml . This version of the pipeline uses ECR instead of GHCR for tests. As a temporary fix for vaccine, dd-trace-rb is published to GHCR as well. This will break when Classic PATs are deprecated