[NO-TICKET] Review and clean up profiler logging #4728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?**
This PR does a pass on the profiler's logging and:
* Lowers the severity of a few messages from error to warn
* Reports a few more messages via telemetry
* Changes a few of the telemetry reports to also include exception
information
**Motivation:**
Recently I was investigating an issue in our reliability environment
and I missed some of the logging I wanted, because it wasn't being
reported using telemetry. So I decided to do that cleanup.
Regarding the error to warn changes, since the profiler failing is not
in any way expected to impact the application, it seems to me that it's
clearer that such failures are warnings ("hey -- something went wrong
and you may not get any profiles").
**Additional Notes:**
N/A
**How to test the change?**
I've updated our unit specs where needed, so we should be good to go.
BenchmarksBenchmark execution time: 2025-06-25 11:24:29 Comparing candidate commit 2ec3903 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics. scenario:error - without error tracking with http
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4728 +/- ##
==========================================
- Coverage 97.54% 97.54% -0.01%
==========================================
Files 1486 1486
Lines 88570 88591 +21
Branches 4587 4591 +4
==========================================
+ Hits 86396 86413 +17
- Misses 2174 2178 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Datadog ReportBranch report: ✅ 0 Failed, 21771 Passed, 1387 Skipped, 5m 8.43s Total Time |
p-datadog
approved these changes
Jun 12, 2025
y9v
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR does a pass on the profiler's logging and:
Motivation:
Recently I was investigating an issue in our reliability environment and I missed some of the logging I wanted, because it wasn't being reported using telemetry. So I decided to do that cleanup.
Regarding the error to warn changes, since the profiler failing is not in any way expected to impact the application, it seems to me that it's clearer that such failures are warnings ("hey -- something went wrong and you may not get any profiles").
Change log entry
Yes. Review and clean up profiler logging
Additional Notes:
N/A
How to test the change?
I've updated our unit specs where needed, so we should be good to go.