DEBUG-3700 more explicitly access active remote #4642
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes
Datadog::Core::Remote.active_remote
and friends and changes the callers of this method to useDatadog.send(:components, allow_initialization: false)
.Motivation:
Making code that intends to read component state only do so, by passing
allow_initialization: false
option toDatadog.send(:components)
. The issue with unconditional initialization is described in #4619.The code in this PR only acts when there is an active remote, and is not designed to initialize the tracer.
Change log entry
None
Additional Notes:
Related: #4641
How to test the change?
Existing tests