-
Notifications
You must be signed in to change notification settings - Fork 476
chore(ai_guard): migrate Evaluation from typed dict to a real object #15840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codeowners resolved as |
Performance SLOsComparing candidate malvarez/ai-guard-evaluation-object (922f65d) with baseline main (f310c58) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 103.941µs (SLO: <130.000µs 📉 -20.0%) vs baseline: +3.3% Memory: ✅ 42.802MB (SLO: <43.250MB 🟡 -1.0%) vs baseline: +5.1% ✅ add_inplace_aspectTime: ✅ 101.507µs (SLO: <130.000µs 📉 -21.9%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.7% ✅ add_inplace_noaspectTime: ✅ 28.154µs (SLO: <40.000µs 📉 -29.6%) vs baseline: -0.2% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ add_noaspectTime: ✅ 48.725µs (SLO: <70.000µs 📉 -30.4%) vs baseline: -0.5% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ bytearray_aspectTime: ✅ 258.582µs (SLO: <400.000µs 📉 -35.4%) vs baseline: +0.9% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.5% ✅ bytearray_extend_aspectTime: ✅ 646.889µs (SLO: <800.000µs 📉 -19.1%) vs baseline: -0.8% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ bytearray_extend_noaspectTime: ✅ 266.844µs (SLO: <400.000µs 📉 -33.3%) vs baseline: -0.4% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.6% ✅ bytearray_noaspectTime: ✅ 141.406µs (SLO: <300.000µs 📉 -52.9%) vs baseline: +0.4% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.8% ✅ bytes_aspectTime: ✅ 221.611µs (SLO: <300.000µs 📉 -26.1%) vs baseline: -0.4% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.8% ✅ bytes_noaspectTime: ✅ 134.280µs (SLO: <200.000µs 📉 -32.9%) vs baseline: +0.4% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.6% ✅ bytesio_aspectTime: ✅ 3.850ms (SLO: <5.000ms 📉 -23.0%) vs baseline: -0.3% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.6% ✅ bytesio_noaspectTime: ✅ 321.336µs (SLO: <420.000µs 📉 -23.5%) vs baseline: +0.3% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ capitalize_aspectTime: ✅ 90.507µs (SLO: <300.000µs 📉 -69.8%) vs baseline: +0.2% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ capitalize_noaspectTime: ✅ 251.725µs (SLO: <300.000µs 📉 -16.1%) vs baseline: +0.5% Memory: ✅ 42.703MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.1% ✅ casefold_aspectTime: ✅ 90.071µs (SLO: <500.000µs 📉 -82.0%) vs baseline: ~same Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.0% ✅ casefold_noaspectTime: ✅ 310.392µs (SLO: <500.000µs 📉 -37.9%) vs baseline: -0.4% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ decode_aspectTime: ✅ 87.230µs (SLO: <100.000µs 📉 -12.8%) vs baseline: ~same Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.2% ✅ decode_noaspectTime: ✅ 155.089µs (SLO: <210.000µs 📉 -26.1%) vs baseline: ~same Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ encode_aspectTime: ✅ 84.801µs (SLO: <200.000µs 📉 -57.6%) vs baseline: -0.6% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ encode_noaspectTime: ✅ 138.268µs (SLO: <200.000µs 📉 -30.9%) vs baseline: -0.4% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.9% ✅ format_aspectTime: ✅ 14.734ms (SLO: <19.200ms 📉 -23.3%) vs baseline: +0.2% Memory: ✅ 42.703MB (SLO: <43.250MB 🟡 -1.3%) vs baseline: +4.9% ✅ format_map_aspectTime: ✅ 16.532ms (SLO: <21.500ms 📉 -23.1%) vs baseline: +0.4% Memory: ✅ 42.703MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ format_map_noaspectTime: ✅ 367.077µs (SLO: <500.000µs 📉 -26.6%) vs baseline: -1.3% Memory: ✅ 42.684MB (SLO: <43.250MB 🟡 -1.3%) vs baseline: +5.1% ✅ format_noaspectTime: ✅ 306.912µs (SLO: <500.000µs 📉 -38.6%) vs baseline: +0.5% Memory: ✅ 42.684MB (SLO: <43.250MB 🟡 -1.3%) vs baseline: +4.9% ✅ index_aspectTime: ✅ 135.048µs (SLO: <300.000µs 📉 -55.0%) vs baseline: +8.8% Memory: ✅ 42.625MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.6% ✅ index_noaspectTime: ✅ 40.442µs (SLO: <300.000µs 📉 -86.5%) vs baseline: -0.7% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.8% ✅ join_aspectTime: ✅ 217.677µs (SLO: <300.000µs 📉 -27.4%) vs baseline: -0.3% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ join_noaspectTime: ✅ 150.989µs (SLO: <300.000µs 📉 -49.7%) vs baseline: -0.1% Memory: ✅ 42.605MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.9% ✅ ljust_aspectTime: ✅ 576.425µs (SLO: <700.000µs 📉 -17.7%) vs baseline: 📈 +15.7% Memory: ✅ 42.605MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.8% ✅ ljust_noaspectTime: ✅ 255.581µs (SLO: <300.000µs 📉 -14.8%) vs baseline: -0.6% Memory: ✅ 42.664MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +5.0% ✅ lower_aspectTime: ✅ 303.103µs (SLO: <500.000µs 📉 -39.4%) vs baseline: ~same Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.8% ✅ lower_noaspectTime: ✅ 233.907µs (SLO: <300.000µs 📉 -22.0%) vs baseline: ~same Memory: ✅ 42.644MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.9% ✅ lstrip_aspectTime: ✅ 0.271ms (SLO: <3.000ms 📉 -91.0%) vs baseline: -0.4% Memory: ✅ 42.644MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.8% ✅ lstrip_noaspectTime: ✅ 0.179ms (SLO: <3.000ms 📉 -94.0%) vs baseline: -0.4% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.0% ✅ modulo_aspectTime: ✅ 14.428ms (SLO: <18.750ms 📉 -23.0%) vs baseline: +0.6% Memory: ✅ 42.762MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.4% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 14.852ms (SLO: <19.350ms 📉 -23.2%) vs baseline: ~same Memory: ✅ 42.782MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.1% ✅ modulo_aspect_for_bytesTime: ✅ 14.536ms (SLO: <18.900ms 📉 -23.1%) vs baseline: +0.2% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 14.668ms (SLO: <19.150ms 📉 -23.4%) vs baseline: -0.3% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ modulo_noaspectTime: ✅ 0.357ms (SLO: <3.000ms 📉 -88.1%) vs baseline: -0.2% Memory: ✅ 42.762MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.9% ✅ replace_aspectTime: ✅ 18.520ms (SLO: <24.000ms 📉 -22.8%) vs baseline: +0.3% Memory: ✅ 42.723MB (SLO: <44.000MB -2.9%) vs baseline: +5.0% ✅ replace_noaspectTime: ✅ 287.360µs (SLO: <300.000µs -4.2%) vs baseline: +0.5% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ repr_aspectTime: ✅ 317.229µs (SLO: <420.000µs 📉 -24.5%) vs baseline: -0.2% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ repr_noaspectTime: ✅ 46.534µs (SLO: <90.000µs 📉 -48.3%) vs baseline: -1.2% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.5% ✅ rstrip_aspectTime: ✅ 375.400µs (SLO: <500.000µs 📉 -24.9%) vs baseline: -0.9% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.6% ✅ rstrip_noaspectTime: ✅ 180.872µs (SLO: <300.000µs 📉 -39.7%) vs baseline: -0.3% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ slice_aspectTime: ✅ 181.994µs (SLO: <300.000µs 📉 -39.3%) vs baseline: +0.1% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.6% ✅ slice_noaspectTime: ✅ 54.275µs (SLO: <90.000µs 📉 -39.7%) vs baseline: -0.6% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.0% ✅ stringio_aspectTime: ✅ 4.474ms (SLO: <5.000ms 📉 -10.5%) vs baseline: 📈 +14.8% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.6% ✅ stringio_noaspectTime: ✅ 353.050µs (SLO: <500.000µs 📉 -29.4%) vs baseline: -0.7% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.7% ✅ strip_aspectTime: ✅ 269.880µs (SLO: <350.000µs 📉 -22.9%) vs baseline: +0.6% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.8% ✅ strip_noaspectTime: ✅ 177.844µs (SLO: <240.000µs 📉 -25.9%) vs baseline: ~same Memory: ✅ 42.743MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.1% ✅ swapcase_aspectTime: ✅ 346.507µs (SLO: <500.000µs 📉 -30.7%) vs baseline: +1.2% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ swapcase_noaspectTime: ✅ 273.452µs (SLO: <400.000µs 📉 -31.6%) vs baseline: +0.2% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.8% ✅ title_aspectTime: ✅ 332.529µs (SLO: <500.000µs 📉 -33.5%) vs baseline: +0.5% Memory: ✅ 42.625MB (SLO: <43.000MB 🟡 -0.9%) vs baseline: +4.9% ✅ title_noaspectTime: ✅ 259.407µs (SLO: <400.000µs 📉 -35.1%) vs baseline: -0.5% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.1% ✅ translate_aspectTime: ✅ 498.322µs (SLO: <700.000µs 📉 -28.8%) vs baseline: -0.3% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ translate_noaspectTime: ✅ 423.580µs (SLO: <500.000µs 📉 -15.3%) vs baseline: -1.5% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ upper_aspectTime: ✅ 306.249µs (SLO: <500.000µs 📉 -38.8%) vs baseline: -0.3% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ upper_noaspectTime: ✅ 233.987µs (SLO: <400.000µs 📉 -41.5%) vs baseline: -0.7% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 505.809µs (SLO: <700.000µs 📉 -27.7%) vs baseline: 📈 +21.3% Memory: ✅ 42.349MB (SLO: <43.500MB -2.6%) vs baseline: +4.6% ✅ ospathbasename_noaspectTime: ✅ 425.052µs (SLO: <700.000µs 📉 -39.3%) vs baseline: ~same Memory: ✅ 42.448MB (SLO: <43.500MB -2.4%) vs baseline: +4.8% ✅ ospathjoin_aspectTime: ✅ 621.465µs (SLO: <700.000µs 📉 -11.2%) vs baseline: -0.2% Memory: ✅ 42.330MB (SLO: <43.500MB -2.7%) vs baseline: +4.6% ✅ ospathjoin_noaspectTime: ✅ 631.081µs (SLO: <700.000µs -9.8%) vs baseline: ~same Memory: ✅ 42.290MB (SLO: <43.500MB -2.8%) vs baseline: +4.7% ✅ ospathnormcase_aspectTime: ✅ 348.825µs (SLO: <700.000µs 📉 -50.2%) vs baseline: ~same Memory: ✅ 42.330MB (SLO: <43.500MB -2.7%) vs baseline: +4.4% ✅ ospathnormcase_noaspectTime: ✅ 358.044µs (SLO: <700.000µs 📉 -48.9%) vs baseline: +0.6% Memory: ✅ 42.408MB (SLO: <43.500MB -2.5%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 486.014µs (SLO: <700.000µs 📉 -30.6%) vs baseline: -0.9% Memory: ✅ 42.467MB (SLO: <43.500MB -2.4%) vs baseline: +5.2% ✅ ospathsplit_noaspectTime: ✅ 496.743µs (SLO: <700.000µs 📉 -29.0%) vs baseline: -0.4% Memory: ✅ 42.428MB (SLO: <43.500MB -2.5%) vs baseline: +5.1% ✅ ospathsplitdrive_aspectTime: ✅ 372.132µs (SLO: <700.000µs 📉 -46.8%) vs baseline: +0.1% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +5.6% ✅ ospathsplitdrive_noaspectTime: ✅ 72.877µs (SLO: <700.000µs 📉 -89.6%) vs baseline: +0.4% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +5.1% ✅ ospathsplitext_aspectTime: ✅ 455.768µs (SLO: <700.000µs 📉 -34.9%) vs baseline: -0.3% Memory: ✅ 42.369MB (SLO: <43.500MB -2.6%) vs baseline: +5.0% ✅ ospathsplitext_noaspectTime: ✅ 463.268µs (SLO: <700.000µs 📉 -33.8%) vs baseline: +0.6% Memory: ✅ 42.389MB (SLO: <43.500MB -2.6%) vs baseline: +4.8% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.438µs (SLO: <20.000µs 📉 -82.8%) vs baseline: 📈 +13.6% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.1% ✅ 1-count-metrics-100-timesTime: ✅ 199.272µs (SLO: <220.000µs -9.4%) vs baseline: +0.4% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.7% ✅ 1-distribution-metric-1-timesTime: ✅ 3.375µs (SLO: <20.000µs 📉 -83.1%) vs baseline: ~same Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.6% ✅ 1-distribution-metrics-100-timesTime: ✅ 215.097µs (SLO: <230.000µs -6.5%) vs baseline: +0.1% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.7% ✅ 1-gauge-metric-1-timesTime: ✅ 2.222µs (SLO: <20.000µs 📉 -88.9%) vs baseline: +1.0% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.356µs (SLO: <150.000µs -9.1%) vs baseline: -0.3% Memory: ✅ 34.957MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.0% ✅ 1-rate-metric-1-timesTime: ✅ 3.182µs (SLO: <20.000µs 📉 -84.1%) vs baseline: +0.4% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 215.006µs (SLO: <250.000µs 📉 -14.0%) vs baseline: ~same Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.0% ✅ 100-count-metrics-100-timesTime: ✅ 19.967ms (SLO: <22.000ms -9.2%) vs baseline: +0.4% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.7% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.220ms (SLO: <2.550ms 📉 -13.0%) vs baseline: +0.7% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.7% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.416ms (SLO: <1.550ms -8.7%) vs baseline: +0.8% Memory: ✅ 34.957MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +4.7% ✅ 100-rate-metrics-100-timesTime: ✅ 2.186ms (SLO: <2.550ms 📉 -14.3%) vs baseline: +0.4% Memory: ✅ 34.977MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +4.8% ✅ flush-1-metricTime: ✅ 4.530µs (SLO: <20.000µs 📉 -77.3%) vs baseline: +0.4% Memory: ✅ 35.212MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +5.4% ✅ flush-100-metricsTime: ✅ 174.023µs (SLO: <250.000µs 📉 -30.4%) vs baseline: -0.4% Memory: ✅ 35.370MB (SLO: <35.500MB 🟡 -0.4%) vs baseline: +5.7% ✅ flush-1000-metricsTime: ✅ 2.190ms (SLO: <2.500ms 📉 -12.4%) vs baseline: -0.2% Memory: ✅ 36.019MB (SLO: <36.500MB 🟡 -1.3%) vs baseline: +4.7% 🟡 Near SLO Breach (14 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Description
Use a proper object instead of a
TypedDictto simplify customer usage.Testing
Risks
Additional Notes