-
Notifications
You must be signed in to change notification settings - Fork 476
ci: migrate codeql workflow to gitlab #15757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
I think we do require having this job, but I saw recently we can run it in GitLab. |
Performance SLOsComparing candidate emmett.butler/codeql-remove (e23473b) with baseline main (e327013) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 17.919µs (SLO: <20.000µs 📉 -10.4%) vs baseline: 📈 +20.7% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.8% ✅ add_inplace_aspectTime: ✅ 15.005µs (SLO: <20.000µs 📉 -25.0%) vs baseline: +0.7% Memory: ✅ 42.585MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.9% ✅ add_inplace_noaspectTime: ✅ 0.338µs (SLO: <10.000µs 📉 -96.6%) vs baseline: -0.3% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ add_noaspectTime: ✅ 0.545µs (SLO: <10.000µs 📉 -94.6%) vs baseline: +0.7% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ bytearray_aspectTime: ✅ 18.135µs (SLO: <30.000µs 📉 -39.6%) vs baseline: +0.1% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ bytearray_extend_aspectTime: ✅ 23.950µs (SLO: <30.000µs 📉 -20.2%) vs baseline: -0.2% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ bytearray_extend_noaspectTime: ✅ 2.737µs (SLO: <10.000µs 📉 -72.6%) vs baseline: -1.3% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ bytearray_noaspectTime: ✅ 1.491µs (SLO: <10.000µs 📉 -85.1%) vs baseline: +0.7% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ bytes_aspectTime: ✅ 16.694µs (SLO: <20.000µs 📉 -16.5%) vs baseline: +1.2% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.1% ✅ bytes_noaspectTime: ✅ 1.421µs (SLO: <10.000µs 📉 -85.8%) vs baseline: ~same Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.9% ✅ bytesio_aspectTime: ✅ 55.722µs (SLO: <70.000µs 📉 -20.4%) vs baseline: ~same Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ bytesio_noaspectTime: ✅ 3.263µs (SLO: <10.000µs 📉 -67.4%) vs baseline: -0.2% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.8% ✅ capitalize_aspectTime: ✅ 14.617µs (SLO: <20.000µs 📉 -26.9%) vs baseline: +0.4% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ capitalize_noaspectTime: ✅ 2.565µs (SLO: <10.000µs 📉 -74.4%) vs baseline: -1.3% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ casefold_aspectTime: ✅ 14.632µs (SLO: <20.000µs 📉 -26.8%) vs baseline: +0.3% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ casefold_noaspectTime: ✅ 3.143µs (SLO: <10.000µs 📉 -68.6%) vs baseline: -0.7% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.7% ✅ decode_aspectTime: ✅ 15.670µs (SLO: <30.000µs 📉 -47.8%) vs baseline: +0.4% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.7% ✅ decode_noaspectTime: ✅ 1.592µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -2.0% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.9% ✅ encode_aspectTime: ✅ 18.165µs (SLO: <30.000µs 📉 -39.4%) vs baseline: 📈 +23.0% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.9% ✅ encode_noaspectTime: ✅ 1.478µs (SLO: <10.000µs 📉 -85.2%) vs baseline: -1.0% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ format_aspectTime: ✅ 170.856µs (SLO: <200.000µs 📉 -14.6%) vs baseline: -0.2% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.7% ✅ format_map_aspectTime: ✅ 191.189µs (SLO: <200.000µs -4.4%) vs baseline: -0.1% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.6% ✅ format_map_noaspectTime: ✅ 3.827µs (SLO: <10.000µs 📉 -61.7%) vs baseline: +1.5% Memory: ✅ 42.585MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +5.0% ✅ format_noaspectTime: ✅ 3.123µs (SLO: <10.000µs 📉 -68.8%) vs baseline: -1.2% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.7% ✅ index_aspectTime: ✅ 15.298µs (SLO: <20.000µs 📉 -23.5%) vs baseline: -0.3% Memory: ✅ 42.546MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.9% ✅ index_noaspectTime: ✅ 0.459µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -1.1% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ join_aspectTime: ✅ 17.118µs (SLO: <20.000µs 📉 -14.4%) vs baseline: +0.7% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ join_noaspectTime: ✅ 1.552µs (SLO: <10.000µs 📉 -84.5%) vs baseline: -0.2% Memory: ✅ 42.585MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +5.0% ✅ ljust_aspectTime: ✅ 20.882µs (SLO: <30.000µs 📉 -30.4%) vs baseline: +0.4% Memory: ✅ 42.664MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.8% ✅ ljust_noaspectTime: ✅ 2.710µs (SLO: <10.000µs 📉 -72.9%) vs baseline: +0.3% Memory: ✅ 42.585MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +5.0% ✅ lower_aspectTime: ✅ 17.974µs (SLO: <30.000µs 📉 -40.1%) vs baseline: -0.5% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +5.0% ✅ lower_noaspectTime: ✅ 2.418µs (SLO: <10.000µs 📉 -75.8%) vs baseline: -0.4% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.9% ✅ lstrip_aspectTime: ✅ 17.653µs (SLO: <30.000µs 📉 -41.2%) vs baseline: +0.3% Memory: ✅ 42.585MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.7% ✅ lstrip_noaspectTime: ✅ 1.870µs (SLO: <10.000µs 📉 -81.3%) vs baseline: +0.1% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ modulo_aspectTime: ✅ 166.138µs (SLO: <200.000µs 📉 -16.9%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 174.497µs (SLO: <200.000µs 📉 -12.8%) vs baseline: -0.4% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.3% ✅ modulo_aspect_for_bytesTime: ✅ 168.577µs (SLO: <200.000µs 📉 -15.7%) vs baseline: -0.2% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.4% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 171.912µs (SLO: <200.000µs 📉 -14.0%) vs baseline: ~same Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.7% ✅ modulo_noaspectTime: ✅ 3.752µs (SLO: <10.000µs 📉 -62.5%) vs baseline: +2.2% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.7% ✅ replace_aspectTime: ✅ 211.790µs (SLO: <300.000µs 📉 -29.4%) vs baseline: -0.2% Memory: ✅ 42.782MB (SLO: <44.000MB -2.8%) vs baseline: +5.1% ✅ replace_noaspectTime: ✅ 2.922µs (SLO: <10.000µs 📉 -70.8%) vs baseline: ~same Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ repr_aspectTime: ✅ 1.413µs (SLO: <10.000µs 📉 -85.9%) vs baseline: -0.5% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ repr_noaspectTime: ✅ 0.522µs (SLO: <10.000µs 📉 -94.8%) vs baseline: ~same Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.7% ✅ rstrip_aspectTime: ✅ 18.960µs (SLO: <30.000µs 📉 -36.8%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ rstrip_noaspectTime: ✅ 2.047µs (SLO: <10.000µs 📉 -79.5%) vs baseline: +4.7% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ slice_aspectTime: ✅ 15.934µs (SLO: <20.000µs 📉 -20.3%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ slice_noaspectTime: ✅ 0.594µs (SLO: <10.000µs 📉 -94.1%) vs baseline: -0.5% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.1% ✅ stringio_aspectTime: ✅ 53.855µs (SLO: <80.000µs 📉 -32.7%) vs baseline: -0.6% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ stringio_noaspectTime: ✅ 3.642µs (SLO: <10.000µs 📉 -63.6%) vs baseline: +0.3% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.6% ✅ strip_aspectTime: ✅ 17.692µs (SLO: <20.000µs 📉 -11.5%) vs baseline: -0.2% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ strip_noaspectTime: ✅ 1.852µs (SLO: <10.000µs 📉 -81.5%) vs baseline: -1.4% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ swapcase_aspectTime: ✅ 18.395µs (SLO: <30.000µs 📉 -38.7%) vs baseline: -0.4% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ swapcase_noaspectTime: ✅ 2.798µs (SLO: <10.000µs 📉 -72.0%) vs baseline: -1.0% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.1% ✅ title_aspectTime: ✅ 21.989µs (SLO: <30.000µs 📉 -26.7%) vs baseline: 📈 +20.3% Memory: ✅ 42.546MB (SLO: <43.000MB 🟡 -1.1%) vs baseline: +4.7% ✅ title_noaspectTime: ✅ 2.666µs (SLO: <10.000µs 📉 -73.3%) vs baseline: -0.3% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.1% ✅ translate_aspectTime: ✅ 20.565µs (SLO: <30.000µs 📉 -31.4%) vs baseline: -0.2% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +5.0% ✅ translate_noaspectTime: ✅ 4.341µs (SLO: <10.000µs 📉 -56.6%) vs baseline: +0.6% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ upper_aspectTime: ✅ 18.005µs (SLO: <30.000µs 📉 -40.0%) vs baseline: +0.2% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.9% ✅ upper_noaspectTime: ✅ 2.440µs (SLO: <10.000µs 📉 -75.6%) vs baseline: +0.9% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.1% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.132µs (SLO: <10.000µs 📉 -48.7%) vs baseline: 📈 +21.0% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.3% ✅ ospathbasename_noaspectTime: ✅ 4.267µs (SLO: <10.000µs 📉 -57.3%) vs baseline: -1.1% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ ospathjoin_aspectTime: ✅ 6.225µs (SLO: <10.000µs 📉 -37.8%) vs baseline: -0.2% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +5.2% ✅ ospathjoin_noaspectTime: ✅ 6.290µs (SLO: <10.000µs 📉 -37.1%) vs baseline: -0.3% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.9% ✅ ospathnormcase_aspectTime: ✅ 3.551µs (SLO: <10.000µs 📉 -64.5%) vs baseline: -0.4% Memory: ✅ 42.389MB (SLO: <43.500MB -2.6%) vs baseline: +4.5% ✅ ospathnormcase_noaspectTime: ✅ 3.634µs (SLO: <10.000µs 📉 -63.7%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.1% ✅ ospathsplit_aspectTime: ✅ 4.889µs (SLO: <10.000µs 📉 -51.1%) vs baseline: -0.5% Memory: ✅ 42.487MB (SLO: <43.500MB -2.3%) vs baseline: +5.0% ✅ ospathsplit_noaspectTime: ✅ 5.008µs (SLO: <10.000µs 📉 -49.9%) vs baseline: ~same Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +4.9% ✅ ospathsplitdrive_aspectTime: ✅ 3.759µs (SLO: <10.000µs 📉 -62.4%) vs baseline: +1.0% Memory: ✅ 42.448MB (SLO: <43.500MB -2.4%) vs baseline: +4.7% ✅ ospathsplitdrive_noaspectTime: ✅ 0.747µs (SLO: <10.000µs 📉 -92.5%) vs baseline: +0.4% Memory: ✅ 42.448MB (SLO: <43.500MB -2.4%) vs baseline: +4.9% ✅ ospathsplitext_aspectTime: ✅ 4.613µs (SLO: <10.000µs 📉 -53.9%) vs baseline: -0.7% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +5.1% ✅ ospathsplitext_noaspectTime: ✅ 4.660µs (SLO: <10.000µs 📉 -53.4%) vs baseline: +0.2% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.9% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.387µs (SLO: <20.000µs 📉 -83.1%) vs baseline: 📈 +12.3% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 199.903µs (SLO: <220.000µs -9.1%) vs baseline: -0.2% Memory: ✅ 34.957MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +4.9% ✅ 1-distribution-metric-1-timesTime: ✅ 3.338µs (SLO: <20.000µs 📉 -83.3%) vs baseline: -0.4% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.1% ✅ 1-distribution-metrics-100-timesTime: ✅ 217.920µs (SLO: <230.000µs -5.3%) vs baseline: +1.7% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ 1-gauge-metric-1-timesTime: ✅ 2.189µs (SLO: <20.000µs 📉 -89.1%) vs baseline: -1.5% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.8% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.215µs (SLO: <150.000µs -9.2%) vs baseline: -0.5% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.2% ✅ 1-rate-metric-1-timesTime: ✅ 3.127µs (SLO: <20.000µs 📉 -84.4%) vs baseline: -0.7% Memory: ✅ 34.996MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +5.2% ✅ 1-rate-metrics-100-timesTime: ✅ 215.463µs (SLO: <250.000µs 📉 -13.8%) vs baseline: +1.1% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.018ms (SLO: <22.000ms -9.0%) vs baseline: +0.8% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.236ms (SLO: <2.550ms 📉 -12.3%) vs baseline: -1.0% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.410ms (SLO: <1.550ms -9.0%) vs baseline: -0.2% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ 100-rate-metrics-100-timesTime: ✅ 2.197ms (SLO: <2.550ms 📉 -13.9%) vs baseline: +1.0% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.9% ✅ flush-1-metricTime: ✅ 4.579µs (SLO: <20.000µs 📉 -77.1%) vs baseline: +0.8% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ flush-100-metricsTime: ✅ 174.217µs (SLO: <250.000µs 📉 -30.3%) vs baseline: -0.5% Memory: ✅ 35.291MB (SLO: <35.500MB 🟡 -0.6%) vs baseline: +5.2% ✅ flush-1000-metricsTime: ✅ 2.174ms (SLO: <2.500ms 📉 -13.0%) vs baseline: -0.8% Memory: ✅ 36.019MB (SLO: <36.500MB 🟡 -1.3%) vs baseline: +4.7% 🟡 Near SLO Breach (16 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Codeowners resolved as |
This adds a trust policy file in support of #15757
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
brettlangdon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment, but otherwise lgtm
This adds a trust policy file in support of #15757
This change moves CodeQL scanning from Github Actions to Gitlab in the interest of reducing the CI's reliance on GHA.