-
Notifications
You must be signed in to change notification settings - Fork 361
fix tracer metadata when optional dependencies are missing #7143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Overall package sizeSelf size: 4.35 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7143 +/- ##
==========================================
+ Coverage 84.76% 84.78% +0.02%
==========================================
Files 521 521
Lines 22151 22156 +5
==========================================
+ Hits 18776 18786 +10
+ Misses 3375 3370 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
BenchmarksBenchmark execution time: 2025-12-18 19:48:50 Comparing candidate commit 3c661a1 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 288 metrics, 32 unstable metrics. |
BridgeAR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think having an additional test case that has none of the optional dependencies installed and using features for all of those would be good as well. Where we have a map of configs that have to be defined for each of them and we check that the map is kept up to date with the entries in the package.json. That way we know that we find all.
What does this PR do?
Fix tracer metadata when optional dependencies are missing.
Motivation
Native addons should always be loaded in a try/catch in case they can't be loaded. This is especially true when they are explicitly not installed, for example when omitting optional dependencies or when bundling the library without the native addons.