Skip to content

Conversation

@simon-id
Copy link
Member

@simon-id simon-id commented Dec 18, 2025

What does this PR do?

Motivation

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Overall package size

Self size: 4.41 MB
Deduped: 5.24 MB
No deduping: 5.24 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@simon-id simon-id self-assigned this Dec 18, 2025
@datadog-official
Copy link

datadog-official bot commented Dec 18, 2025

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 178 Tests failed

tests.appsec.api_security.test_apisec_sampling.Test_API_Security_Sampling_Different_Endpoints.test_sampling_delay[express4] from system_tests_suite (Datadog) (Fix with Cursor)
assert None is not None

self = <tests.appsec.api_security.test_apisec_sampling.Test_API_Security_Sampling_Different_Endpoints object at 0x7fed9df91a90>

    def test_sampling_delay(self):
        assert self.request1.status_code == 200
        schema1 = get_schema(self.request1, "req.headers")
>       assert schema1 is not None
E       assert None is not None

...
tests.appsec.api_security.test_apisec_sampling.Test_API_Security_Sampling_Different_Endpoints.test_sampling_delay[express4-typescript] from system_tests_suite (Datadog) (Fix with Cursor)
assert None is not None

self = <tests.appsec.api_security.test_apisec_sampling.Test_API_Security_Sampling_Different_Endpoints object at 0x7f1af07b7770>

    def test_sampling_delay(self):
        assert self.request1.status_code == 200
        schema1 = get_schema(self.request1, "req.headers")
>       assert schema1 is not None
E       assert None is not None

...
tests.appsec.api_security.test_apisec_sampling.Test_API_Security_Sampling_Different_Endpoints.test_sampling_delay[express5] from system_tests_suite (Datadog) (Fix with Cursor)
assert None is not None

self = <tests.appsec.api_security.test_apisec_sampling.Test_API_Security_Sampling_Different_Endpoints object at 0x7fbd942c1310>

    def test_sampling_delay(self):
        assert self.request1.status_code == 200
        schema1 = get_schema(self.request1, "req.headers")
>       assert schema1 is not None
E       assert None is not None

...
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: bf80a9a | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.39%. Comparing base (a18c971) to head (bf80a9a).

Files with missing lines Patch % Lines
packages/dd-trace/src/appsec/index.js 18.75% 13 Missing ⚠️
...ages/datadog-instrumentations/src/helpers/hooks.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7138      +/-   ##
==========================================
- Coverage   84.49%   79.39%   -5.11%     
==========================================
  Files         524      523       -1     
  Lines       22463    22315     -148     
==========================================
- Hits        18981    17717    -1264     
- Misses       3482     4598    +1116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Dec 18, 2025

Benchmarks

Benchmark execution time: 2025-12-24 16:01:04

Comparing candidate commit bf80a9a in PR branch stripe_business_events with baseline commit a18c971 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 292 metrics, 28 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants