DRAFT: AI WRITTEN INTEGRATION bullmq #7123

wconti27 · 2025-12-16T23:42:13Z

What does this PR do?

AI GENERATED integration for bullmq

Motivation

Plugin Checklist

Additional Notes

github-actions · 2025-12-16T23:43:03Z

Overall package size

Self size: 4.35 MB
Deduped: 5.23 MB
No deduping: 5.23 MB

Dependency sizes

| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

codecov · 2025-12-16T23:43:03Z

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.74%. Comparing base (c67f394) to head (c472a1d).

Files with missing lines	Patch %	Lines
...d-trace/src/service-naming/schemas/v0/messaging.js	0.00%	4 Missing ⚠️
...ages/datadog-instrumentations/src/helpers/hooks.js	0.00%	1 Missing ⚠️
packages/dd-trace/src/plugins/index.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                      Coverage Diff                      @@
##           conti/all-tooling-changes    #7123      +/-   ##
=============================================================
- Coverage                      84.77%   84.74%   -0.04%     
=============================================================
  Files                            521      521              
  Lines                          22162    22162              
=============================================================
- Hits                           18788    18781       -7     
- Misses                          3374     3381       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

wconti27 · 2025-12-16T23:43:11Z

packages/dd-trace/test/plugins/versions/package.json

  "private": true,
  "dependencies": {
    "@ai-sdk/openai": "2.0.65",
    "@anthropic-ai/sdk": "0.68.0",


workflow sorts this file, so that explains the sorting change. really only 1 line for bullmq was added

packages/dd-trace/test/setup/helpers/load-inst.js

wconti27 · 2025-12-16T23:45:50Z

packages/datadog-plugin-bullmq/test/index.spec.js

+  describe('Queue.add() - bullmq.add', () => {
+    it('should generate span with correct tags (happy path)', async () => {
+      const traceAssertion = agent.assertSomeTraces((traces) => {
+        const spans = traces[0]


Would prefer using the assertFirstTrace function that supports including the span object shape instead of separate assertion lines. assertFirstTrace name may be confusing the agent.

pr-commenter · 2025-12-16T23:52:59Z

Benchmarks

Benchmark execution time: 2025-12-22 18:38:08

Comparing candidate commit c472a1d in PR branch conti/bullmq-auto-generated with baseline commit c67f394 in branch conti/all-tooling-changes.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 288 metrics, 32 unstable metrics.

simon-id · 2025-12-17T04:09:39Z

.github/workflows/apm-integrations.yml

+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+      - uses: ./.github/actions/plugins/test
+        with:
+          dd_api_key: ${{{{ secrets.DD_API_KEY }}}}


damn son, heard you like curly braces

This happened in the NATS PR as well

easy fix! And simon's comment made me "lol"

wconti27 · 2025-12-17T21:14:16Z

packages/datadog-instrumentations/src/helpers/rewriter/instrumentations/index.js


 module.exports = [
-  ...require('./langchain')
+  ...require('./langchain'),


need to add this change to node file generators.

tlhunter · 2025-12-17T21:43:25Z

packages/datadog-plugin-bullmq/test/index.spec.js

+        const producerSpan = spans.find(span => span.name === 'bullmq.add')
+        if (!producerSpan) {
+          throw new Error('Producer span bullmq.add not found')
+        }


Something like this would be more idiomatic:

Suggested change

const producerSpan = spans.find(span => span.name === 'bullmq.add')

if (!producerSpan) {

throw new Error('Producer span bullmq.add not found')

}

const producerSpan = spans.find(span => span.name === 'bullmq.add')

expect(producerSpan, 'Producer span bullmq.add not found').to.be.ok

tlhunter · 2025-12-17T21:50:30Z

docker-compose.yml

  redis:
-    image: redis:4.0-alpine
+    image: redis:7.0-alpine
    ports:
      - "127.0.0.1:6379:6379"


I think this is okay... Redis is good about backwards compatibility. So even though we're testing old library versions they should behave the same with a newer Redis.

Another approach is to add a separate image just for bullmq stuff:

redis: image: redis:7.0-alpine ports: - "127.0.0.1:16379:6379"

^ that would avoid port conflicts and would also need the test code to use port 16379 instead of the default 6379. But I'll defer to others.

tlhunter · 2025-12-17T21:53:30Z

Shouldn't there be a new Platform / instrumentation-bullmq (pull_request) action?

wconti27 · 2025-12-17T23:42:03Z

Shouldn't there be a new Platform / instrumentation-bullmq (pull_request) action?

@tlhunter What is this? I'm not aware of what this is

datadog-datadog-prod-us1 · 2025-12-18T15:46:37Z

⚠️ Tests

✨ Fix all issues with Cursor

⚠️ Warnings

❄️ 1 New flaky test detected

[email protected] esm flaky test retries retries DD_CIVISIBILITY_FLAKY_RETRY_COUNT times from integration-tests/cypress/cypress.spec.js (Datadog) (Fix with Cursor)
Expected values to be strictly equal:

0 !== 1

ℹ️ Info

🧪 All tests passed

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: c472a1d | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

tlhunter · 2025-12-18T19:54:29Z

@wconti27 What is this? I'm not aware of what this is

I was saying we need a new test to appear in the list of github actions that have executed as a result of this pull request. Such a test was not present when I reviewed previously but is now working.

tlhunter · 2025-12-18T19:57:20Z

packages/datadog-plugin-bullmq/test/index.spec.js

+  const edgeTags = isProducer
+    ? ['direction:out', `topic:${queueName}`, 'type:bullmq']
+    : ['direction:in', `topic:${queueName}`, 'type:bullmq']


Suggested change

const edgeTags = isProducer

? ['direction:out', `topic:${queueName}`, 'type:bullmq']

: ['direction:in', `topic:${queueName}`, 'type:bullmq']

const edgeTags = [isProducer ? 'direction:out' : 'direction:in', `topic:${queueName}`, 'type:bullmq']

…ated

bullmq integration

b310a2b

wconti27 self-assigned this Dec 16, 2025

wconti27 commented Dec 16, 2025

View reviewed changes

packages/dd-trace/test/setup/helpers/load-inst.js Show resolved Hide resolved

wconti27 commented Dec 16, 2025

View reviewed changes

wconti27 added the AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos label Dec 16, 2025

simon-id reviewed Dec 17, 2025

View reviewed changes

wconti27 commented Dec 17, 2025

View reviewed changes

tlhunter reviewed Dec 17, 2025

View reviewed changes

fix github action

d026b6c

wconti27 added 2 commits December 18, 2025 10:57

add redis to externals json

0fda6be

remove load inst change

80f92ac

wconti27 requested a review from tlhunter December 18, 2025 16:01

tlhunter reviewed Dec 18, 2025

View reviewed changes

Merge branch 'conti/all-tooling-changes' into conti/bullmq-auto-gener…

c472a1d

…ated

DRAFT: AI WRITTEN INTEGRATION bullmq #7123

Are you sure you want to change the base?

DRAFT: AI WRITTEN INTEGRATION bullmq #7123

Conversation

wconti27 commented Dec 16, 2025

What does this PR do?

Motivation

Plugin Checklist

Additional Notes

Uh oh!

github-actions bot commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overall package size

Uh oh!

codecov bot commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pr-commenter bot commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tlhunter commented Dec 17, 2025

Uh oh!

wconti27 commented Dec 17, 2025

Uh oh!

datadog-datadog-prod-us1 bot commented Dec 18, 2025 • edited by datadog-official bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

ℹ️ Info

Uh oh!

tlhunter commented Dec 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Dec 16, 2025 •

edited

Loading

codecov bot commented Dec 16, 2025 •

edited

Loading

pr-commenter bot commented Dec 16, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Dec 18, 2025 •

edited by datadog-official bot

Loading