contrib/gomongodb.org/mongo-driver: add optional query tag truncation #3679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What does this PR do? This PR adds support for a `WithMaxQuerySize` method to the MongoDB package that enables truncation on the `mongodb.query` span tag. I also ported this behavior to the new `mongo-driver.v2` package which supports the v2 release of the Mongo drivers. Opening this PR here first for feedback from our team and then will open on the upstream repo. The default is to not truncate query span tags, to avoid breaking changes. I'll ask in the upstream PR about whether we could truncate by default instead. ### Motivation This reduces the memory footprint of tracing Mongo applications that write large documents.
This PR updates the behavior of `WithMaxQuerySize` when `max=0` to avoid attaching the query tag entirely. This is more intuitive ("max query size of zero") and gives folks a way to disable serializing the command entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for a
WithMaxQuerySizeoption to the MongoDB module that configures truncation on themongodb.queryspan tag.Ideally, we default to enabling truncation. However, this PR currently maintains backwards-compatibility by defaulting to no truncation. I'll defer to the DataDog team on whether we can change this default.
I've also ported this behavior to the
mongo-driver.v2module.Fixes #3672
Motivation
See: #3672
Reviewer's Checklist
golangci-lint runlocally.Unsure? Have a question? Request a review!