Skip to content

envoyproxy: body parsing support #3671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eliottness merged 26 commits into from
Jun 26, 2025
Merged

envoyproxy: body parsing support #3671

eliottness merged 26 commits into from
Jun 26, 2025

Conversation

@e-n-0
Copy link
Member

@e-n-0 e-n-0 commented Jun 19, 2025 •
edited
Loading

What does this PR do?

  • Implement parsing of request and response bodies (usage of allow_mode_override mandatory in Envoy config)
  • Link body parsing with the json encoder contrib/envoyproxy: add JSON Encoder #3550
  • Refactor of the contrib for better readability / clean code
  • Implement a fix for URL escaped (failed to unescape with url.Parse with path including bad encoded values) (more info)

Motivation

Implement body parsing for the Envoy proxy integration (RFC).

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Jun 19, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jun 19, 2025 •
edited
Loading

Benchmarks

Benchmark execution time: 2025-06-26 21:38:36

Comparing candidate commit 399ea9e in PR branch flavien/envoy/body-parsing with baseline commit cb65a92 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@e-n-0 e-n-0 force-pushed the flavien/envoy/body-parsing branch 2 times, most recently from f045f0b to 9fbc38d Compare June 24, 2025 14:05
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 24, 2025 •
edited
Loading

Datadog Report

Branch report: flavien/envoy/body-parsing
Commit report: e922080
Test service: dd-trace-go

✅ 0 Failed, 5420 Passed, 66 Skipped, 4m 25.85s Total Time

@eliottness eliottness force-pushed the flavien/envoy/body-parsing branch from 8f2a2e6 to 1f3d9b3 Compare June 25, 2025 11:05
e-n-0 and others added 15 commits June 25, 2025 13:51
@eliottness eliottness force-pushed the flavien/envoy/body-parsing branch from 1f3d9b3 to b7035cf Compare June 25, 2025 13:52
@e-n-0 e-n-0 marked this pull request as ready for review June 25, 2025 16:11
@e-n-0 e-n-0 requested a review from a team as a code owner June 25, 2025 16:11
eliottness
eliottness approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@eliottness eliottness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@eliottness
run ./scripts/fix_modules.sh
1f15023 
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness eliottness enabled auto-merge (squash) June 25, 2025 16:19
@eliottness eliottness merged commit fe9272d into main Jun 26, 2025
240 checks passed
@eliottness eliottness deleted the flavien/envoy/body-parsing branch June 26, 2025 21:46
eliottness added a commit that referenced this pull request Jul 9, 2025
@e-n-0 @eliottness
envoyproxy: body parsing support (#3671)
3c68f0f 
Co-authored-by: Eliott Bouhana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eliottness eliottness eliottness approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@e-n-0 @eliottness