Skip to content

Conversation

@dolmen
Copy link
Contributor

@dolmen dolmen commented Jun 10, 2025

What does this PR do?

Improve Go doc of package contrib/hashicorp/vault by using godoc links.

Motivation

Improved readability of the documentation thanks to cross links.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

@dolmen dolmen requested review from a team as code owners June 10, 2025 07:38
@dolmen dolmen force-pushed the contrib-vault-godoc branch from 3c956eb to b1e5f2b Compare June 10, 2025 07:39
@kakkoyun kakkoyun enabled auto-merge (squash) June 10, 2025 08:22
auto-merge was automatically disabled June 10, 2025 12:10

Head branch was pushed to by a user without write access

@dolmen dolmen force-pushed the contrib-vault-godoc branch from b1e5f2b to 12aab99 Compare June 10, 2025 12:10
@kakkoyun kakkoyun enabled auto-merge (squash) June 11, 2025 07:34
@rarguelloF
Copy link
Contributor

Hi @dolmen,

Thanks for the PR, we really appreciate your contribution!

Currently, this PR cannot be merged because of the new repository requirement (Commits need to be signed). So if possible, could you:

  • If you’re comfortable doing so, feel free to GPG-sign the commits yourself to comply with the repo’s commit policy.
  • Otherwise, please enable the “Allow edits from maintainers” option on this PR on your fork so we can sign the commits on your behalf.

Thanks!

@kakkoyun kakkoyun merged commit d56556a into DataDog:main Jul 24, 2025
103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants