Skip to content

Conversation

@merakulix
Copy link
Contributor

@merakulix merakulix commented Dec 1, 2025

The path of a CCPACSExternalObject was not accessible while reloading configuration.

Description

When updating the CPACS configuration after undo/redo the path gets saved temporarily and added to tixi handle.

When creating new configurations, that are not yet saved, the file path is not known, which is intuitive for new files, but a problem when needing to reload for theses processes.

Fixes #1219
Requires next TiXI release because the fix depends on a newly implemented function in TiXI. See TiXI issue 257 and TiXI PR 258

How Has This Been Tested?

In GUI, Step geometry get's reloaded now.

Screenshots, that help to understand the changes(if applicable):

Checklist:

Task Finished Reviewer Approved
At least one test for the new functionality was added.
  • yes
  • does not apply
  • OK
New classes have been added to the Python interface.
  • yes
  • does not apply
  • OK
The code is properly documented with doxygen docstrings
  • yes
  • does not apply
  • OK
Changes are documented at the top of ChangeLog.md
  • yes
  • does not apply
  • OK

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.75%. Comparing base (08f4898) to head (d48e999).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1266   +/-   ##
=======================================
  Coverage   72.75%   72.75%           
=======================================
  Files         308      308           
  Lines       26993    26993           
=======================================
  Hits        19638    19638           
  Misses       7355     7355           
Flag Coverage Δ
unittests 72.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TiGL Creator: External linked step geometries get lost after undo

2 participants