Skip to content

Conversation

@joergbrech
Copy link
Contributor

@joergbrech joergbrech commented Dec 3, 2024

Fixes #1037

Description

This PR adds the missing#include and %include statements to the swig interface file configuration.i.

How Has This Been Tested?

Screenshots, that help to understand the changes(if applicable):

Not applicable.

Checklist:

Task Finished Reviewer Approved
At least one test for the new functionality was added.
  • yes
  • does not apply
  • OK
New classes have been added to the Python interface.
  • yes
  • does not apply
  • OK
The code is properly documented with doxygen docstrings
  • yes
  • does not apply
  • OK
Changes are documented at the top of ChangeLog.md
  • yes
  • does not apply
  • OK

@codecov
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.88%. Comparing base (6d414b0) to head (fc5b873).

Files with missing lines Patch % Lines
src/fuselage/CTiglStringerFrameBorderedObject.cpp 0.00% 12 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1041      +/-   ##
==========================================
- Coverage   69.91%   69.88%   -0.03%     
==========================================
  Files         294      294              
  Lines       27288    27299      +11     
==========================================
  Hits        19078    19078              
- Misses       8210     8221      +11     
Flag Coverage Δ
unittests 69.88% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/fuselage/CTiglStringerFrameBorderedObject.cpp 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joergbrech joergbrech marked this pull request as draft January 2, 2025 10:31
@merakulix
Copy link
Contributor

Short update: CCPACSkin is available now via Python Bindings, CPACSSkinSegments as well. I also tested some of the getter functions of boost::optional types in CCPACSFuselageStructure, such as stringers, frames, cargo_cross_beams, cargo_cross_beam_struts, which are also available now. As discussed with @joergbrech, see RISCSoftware/cpacs_tigl_gen#59 about the getter functions for the vector elements

@joergbrech joergbrech changed the base branch from tigl-3-4-1 to main September 10, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Several fuslage python bindings seem to be broken

3 participants