Skip to content

Otel metrics change intervals #4170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 8, 2025

Conversation

dsessler7
Copy link
Contributor

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

Some metric queries are not running at ideal intervals.

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

A couple metrics queries were moved to more appropriate intervals.
Also, the initial delay for the sqlquery receivers has been increased to avoid attempting to authenticate before sql setup has completed.

Other Information:

Copy link
Contributor

@benjaminjb benjaminjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me just make sure I've got this right:

  • some queries were only running in the wrong time period
  • you moved these queries to other / new files
  • to help clarify when queries should run, you set a new pattern where every file is either fast or slow
  • not every version-based query has both fast & slow query files

I think that all makes sense, but happy to talk it over too.

@dsessler7
Copy link
Contributor Author

Let me just make sure I've got this right:

* some queries were only running in the wrong time period

* you moved these queries to other / new files

* to help clarify when queries should run, you set a new pattern where every file is either fast or slow

* not every version-based query has both fast & slow query files

I think that all makes sense, but happy to talk it over too.

That's exactly correct.

The bump to the initial_delay seems to be causing the OTel kuttl test to fail on finding the 5 minute metric. I'm going to move the check for 5 minute metrics to be the last thing we check for to see if that gets it passing again.

@dsessler7 dsessler7 force-pushed the otel-metrics-change-intervals branch 2 times, most recently from 10102d1 to ee695bf Compare May 7, 2025 22:57
@dsessler7 dsessler7 requested a review from benjaminjb May 8, 2025 02:04
dsessler7 added 3 commits May 8, 2025 09:14
Move ccp_stat_user_tables metrics/query to 5 minute interval receiver.
Add comment about null values to ccp_replication_slots metrics/query.
@dsessler7 dsessler7 force-pushed the otel-metrics-change-intervals branch from ee695bf to 6f831e9 Compare May 8, 2025 16:15
@dsessler7 dsessler7 merged commit dd5204a into CrunchyData:main May 8, 2025
19 checks passed
@dsessler7 dsessler7 deleted the otel-metrics-change-intervals branch May 8, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants