Fix Refs #696: bluespec special constFp #703
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…special floating point values in a suite that does not compile before the fix for 696
…nstFp to preserve special Double values Const fp previously only checked if a number was negative or not but failed to create valid bluespec values on special Doubles (inf, -inf, sNaN, qNaN, -0.0). This was previously not captured in tests since the testing aparatus has a special-Double-friendly way of making bluespec values for testing. This fix can be seen in the now-compiling version of examples/special_doubles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #696
The previous usage of
constFpin Copilot-Bluespec did not correctly translate special double-width floating point values. This PR implements a fix and a proof-of-concept example.The example does not compile before the fix but does compile after the patch, giving the expected bit-representations of the floating point values.
Interestingly this issue was not caught before during testing because the test suite uses a different method for deriving the Bluespec versions of floating point values that was not used in the public-facing reification. For that reason I provide the example directory that demonstrates the error (because a test would not work).